Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't read past end-of-string in quoted case of concat_argv #634

Merged
merged 1 commit into from
Jul 4, 2017
Merged

don't read past end-of-string in quoted case of concat_argv #634

merged 1 commit into from
Jul 4, 2017

Conversation

rolandwalker
Copy link
Contributor

Incidentally remove unused pos.

This was corrupting some strings. On OS X it's pretty easy to trigger by

bind generic n  ?echo "one two" three " " four

and then pressing "n" several times.

@rolandwalker
don't read past end-of-string in concat_argv
e5c749e 
quoted case only. was corrupting some strings.  remove unused pos.
@jonas jonas merged commit 077f9db into jonas:master Jul 4, 2017
@jonas
Copy link
Owner

jonas commented Jul 4, 2017

Thanks and nice cleanup.

@rolandwalker rolandwalker deleted the quoted-argv-corruption branch July 4, 2017 01:45
@jonas jonas modified the milestone: tig-2.3 Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
tig-2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rolandwalker @jonas