flush buffered keystrokes after external viewer #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this will fix #232 |
|
I misread, but hope to have found a fix for #232 because of this ticket. |
jonas
reviewed
Jul 14, 2017
src/display.c
Outdated
| @@ -64,6 +64,9 @@ open_external_viewer(const char *argv[], const char *dir, bool silent, bool conf | |||
| fprintf(stderr, "%s", notice); | |||
| fprintf(stderr, "Press Enter to continue"); | |||
| getc(opt_tty); | |||
| opt_tty = freopen(NULL, "r", opt_tty); | |||
There was a problem hiding this comment.
If I read freopen(3) correctly, the mode should be "w+" to match how it is initially opened in pager mode:
Line 557 in 1f757f6
|
Looks good to me, but I am not sure if this means that the terminal also needs to be reopened somehow. From my understanding of how |
|
Also somewhat related to the suspending cleanups in #657 |
rolandwalker
force-pushed
the
flush-after-external-viewer
branch
from
c5f9b14 to
cb17007
Compare
|
Seeking to I missed #657 and haven't tested the interactions. |
|
Yes, that looks safer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by
reopening the TTYseeking toSEEK_END. Otherwise keystrokes pressed prior to Enter hang around and can get read later.To reproduce:
:bind generic o !lsqunflushed