Commit cdadc8a
committed
[Xamarin.Android.Build.Tasks] only update typemap timestamps if changes occur
Context: dotnet#1930
Since 3d999d3, `Fast Deployment` has been rebuilding the APK when it
shouldn't. Apparently the `typemap.mj` and `typemap.jm` files'
timestamps are used when deciding to repack/deploy the APK or not.
After looking at my `CheckTimestamps` test, I don't think it was quite
right. It should modify `MainActivity`'s type name so that these files
will be updated. Just modifying code won't invalidate these files.
Then the `GenerateJavaStubs` task should only update the timestamps if
the file was actually changed, which should fix `Fast Deployment`.1 parent 8b7411b commit cdadc8a
File tree
2 files changed
+5
-4
lines changed- src/Xamarin.Android.Build.Tasks
- Tasks
- Tests/Xamarin.Android.Build.Tests
2 files changed
+5
-4
lines changedLines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
306 | 306 | | |
307 | 307 | | |
308 | 308 | | |
309 | | - | |
310 | | - | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
311 | 312 | | |
312 | 313 | | |
313 | 314 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
230 | | - | |
231 | | - | |
| 230 | + | |
| 231 | + | |
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
| |||
0 commit comments