Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails check updated #15

Merged

Conversation

kendrikat
Copy link
Contributor

Hi, we are not using Rails, but actionmailer (4.2.4) which depends on rails-dom-testing which has a Rails module https://github.com/rails/rails-dom-testing/blob/5efc948e3572906965c4ed2f67000e59a7094e62/lib/rails/dom/testing/version.rb

module Rails
  module Dom
    module Testing
      VERSION = "2.0.1"
    end
  end
end

Gemfile.lock:

actionmailer (4.2.4)
  actionpack (= 4.2.4)
  actionview (= 4.2.4)
  activejob (= 4.2.4)
  mail (~> 2.5, >= 2.5.4)
  rails-dom-testing (~> 1.0, >= 1.0.5) 

This change seems to fix it.

@jonathanwiesel
Copy link
Contributor

I guess this is the same scenario presented in amatsuda/kaminari#796

@jonathanwiesel jonathanwiesel added this to the v3.0.0 milestone Jun 28, 2016
@jonathanwiesel jonathanwiesel merged commit cfc0f35 into bonusly:master Jun 28, 2016
@kendrikat
Copy link
Contributor Author

🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants