Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'test' directory from .gitignore #5

Closed
fyockm opened this issue Feb 12, 2014 · 6 comments
Closed

remove 'test' directory from .gitignore #5

fyockm opened this issue Feb 12, 2014 · 6 comments

Comments

@fyockm
Copy link
Contributor

fyockm commented Feb 12, 2014

Please remove test directory from .gitignore and commit your tests, so contributors can run the same tests. grunt test doesn't work so well without them 😄

@jonschlinkert
Copy link
Owner

agreed. want to do a pr? or I can do it as soon as I get a chance. thanks!

@fyockm
Copy link
Contributor Author

fyockm commented Feb 12, 2014

@jonschlinkert I removed test with my PR for #6, which you merged. So that part is already done. I would prefer that you commit your tests when you get a chance, as a base.

@fyockm
Copy link
Contributor Author

fyockm commented Sep 15, 2014

@jonschlinkert any chance you could commit your local tests too? I would have included some tests for #10 if the structure was already in place.

@jonschlinkert
Copy link
Owner

sorry, I remember why I had tests ignored. I was porting the tests over to use assert/bsd style tests. when I get around to finishing that I'll push them up.

@fyockm
Copy link
Contributor Author

fyockm commented Sep 15, 2014

Ok, I'll stop hassling you about it 😉

@jonschlinkert
Copy link
Owner

Closing, I couldn't do this if I wanted to now, the computer I used at the time died and I recovered zero from it. lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants