Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External URL menu links mixed up #60

Closed
swthemathwiz opened this issue Jul 5, 2019 · 2 comments
Closed

External URL menu links mixed up #60

swthemathwiz opened this issue Jul 5, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@swthemathwiz
Copy link

I created a menu item type URL that linked to an external site (e.g. http://www.google.com), but the link was consistently incorrect. I traced the problem to this file:

astroid-template-zero/frontend/header/menu/link.php

Around line 104, I think it's supposed to search for a '#' as the first character, but instead matches anything without a '#'. The strpos comparison should be $validonepagelink === 0 not == '0'. So:

if($validonepagelink == '0' && (strlen($item->link) > 1)){

Should be:

if($validonepagelink === 0 && (strlen($item->link) > 1)){

chetanmadaan added a commit that referenced this issue Jul 5, 2019
@chetanmadaan
Copy link
Member

Thanks. You are right, I applied a fix, Can you try out the dev version and see if that fixes it.

Thanks,
Chetan

@chetanmadaan chetanmadaan self-assigned this Jul 5, 2019
@chetanmadaan chetanmadaan added the bug Something isn't working label Jul 5, 2019
@swthemathwiz
Copy link
Author

Tried the file, and it is fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants