Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] [a11y] Proposal remove popovers and replace with inline text #17044

Closed
brianteeman opened this issue Jul 10, 2017 · 1 comment
Closed

[4.0] [a11y] Proposal remove popovers and replace with inline text #17044

brianteeman opened this issue Jul 10, 2017 · 1 comment
Labels
No Code Attached Yet

Comments

@brianteeman
Copy link
Contributor

brianteeman commented Jul 10, 2017 •
edited by joomla-cms-bot
Loading

Tooltips are a nightmare. With the current code they are completely non accessible to non-mouse users and they also can not be used on a touch device so we shouldnt rely on them.

Not all users will see tooltips so they must not include essential information.

It is possible to correct that (see https://www.sarasoueidan.com/blog/accessible-tooltips/ or http://accessibility.athena-ict.com/aria/examples/tooltip.shtml) but do we really need to.

A tooltip or hint should not exist if it simply repeats the content of the label. It should only exist if it provides additional explanatory content. It is not intended to be a manual!!

Because of our previous desire (incorrectly) to have a tooltip for everything a large percentage of tooltips are completely useless and do not add anything. They also require translators to waste a lot of time translating strings that are not needed.

Examples

100% duplicate


COM_MODULES_FIELD_CONTENT_DESC="Text"
COM_MODULES_FIELD_CONTENT_LABEL="Text"

Not required

COM_MODULES_FIELD_CLIENT_ID_DESC="The location of the module, Frontend or Backend. You can't change this value."
COM_MODULES_FIELD_CLIENT_ID_LABEL="Module Location"

EXAMPLE

As can be seen on the screenshot below which exposes the tooltips three of the four on that page are completely redundant and can be removed
menus edit item joomla4 administration

PROPOSAL

Tooltips are removed and replaced with inline hints ONLY where needed

Workflow

  • Step 1 - change tooltips to inline hints so we can see what is needed
  • Step 2 - remove all duplicate labels and unrequired labels
  • Step 3 - check all the hints that are really long help manuals and not hints
  • Step 4 - decide on the best design layout for the hints
@C-Lodder C-Lodder mentioned this issue Jul 10, 2017
Merged
@brianteeman brianteeman changed the title [4.0] [a11y] Proposal remove tooltips and replace with inline text [4.0] [a11y] Proposal remove popovers and replace with inline text Jul 10, 2017
@joomla joomla deleted a comment from C-Lodder Jul 10, 2017
@wilsonge
Copy link
Contributor

I'm largely down with this. I mean let's see how many useful tooltips are left and whether they can go in line. But massive 👍 on removing all the many redundant tips

brianteeman added a commit that referenced this issue Jul 11, 2017
@brianteeman
[4.0] com_banners remove popover
31b2a08 
This is a proof of concept for #17044 to remove the redundant popovers.

PURELY for the purpose of testing this concept I have quickly displayed the remaining popover as inline text - THIS PART IS NOT FOR REVIEW - it is just to demonstrate how few remaining descriptions we will have

In addition you will notice that the remainining descriptions are not very good. They are manuals not tips, hints or descritpions and can be drastically reduced or rewritten. AGAIN this text is not for review here
@brianteeman brianteeman mentioned this issue Jul 11, 2017
Merged
wilsonge pushed a commit that referenced this issue Jul 28, 2017
@brianteeman @wilsonge
[4.0] remove popover (#17071)
e4b9c4d 
* [4.0] com_banners remove popover

This is a proof of concept for #17044 to remove the redundant popovers.

PURELY for the purpose of testing this concept I have quickly displayed the remaining popover as inline text - THIS PART IS NOT FOR REVIEW - it is just to demonstrate how few remaining descriptions we will have

In addition you will notice that the remainining descriptions are not very good. They are manuals not tips, hints or descritpions and can be drastically reduced or rewritten. AGAIN this text is not for review here

* demonstration only

* add com_content config options

* contact item

* one more

* missed one

* added com_users

* menus

* finish com_menus

* com_joomlaupdate

* com_messages

* com_messages

* com_newsfeeds

* com_redirects

* com_search

* com_finder

* com_tags

* com_templates

* com_templates

* com_plugins

* modules first pass

* com_content, com_categories and various

* user profile

* profile again

* com_admin, com_config

* cleanup

* com_fields, com_languages

* user plugins

* plugins two factor

* plugins system

* plugins search

* plugins - authentication

* plugins - captcha

* plugins - content

* plugins - editors

* plugins fields

* oops forgot some modules

* front end views and menu options

* further review

* mod _related

* further remove

* pagination results to pagination summary

* tabs

* language stemmer

* undo

* show rss link

* oops i forgot the tags component

* missed some

* com-config tidyup

* unused banners strings

* unused strings

* frontend edit profile

* mod_feed

* mod articles latest

* modules

* more module stuff

* Labels and descriptions are not used in filters

* review again

* complete module review

* plugin review

* oops i forgot to save this file before committing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brianteeman @wilsonge @joomla-cms-bot