From abccdaf8c45ba2c5ccd99e485294bd65699857a9 Mon Sep 17 00:00:00 2001
From: zero-24 <zero-24@users.noreply.github.com>
Date: Mon, 13 Feb 2017 10:27:04 +0100
Subject: [PATCH 1/3] Update modal.php

---
 .../com_users/views/users/tmpl/modal.php      | 55 +++++++++----------
 1 file changed, 27 insertions(+), 28 deletions(-)

diff --git a/administrator/components/com_users/views/users/tmpl/modal.php b/administrator/components/com_users/views/users/tmpl/modal.php
index 29c2e5721b815..3882bf6809e97 100644
--- a/administrator/components/com_users/views/users/tmpl/modal.php
+++ b/administrator/components/com_users/views/users/tmpl/modal.php
@@ -36,7 +36,7 @@
  *
  * This should be removed when mootools won't be shipped by Joomla.
  */
-$isMoo      = $input->getInt('ismoo', 1);
+$isMoo = $input->getInt('ismoo', 1);
 
 if ($isMoo)
 {
@@ -89,32 +89,31 @@
 				</tr>
 			</tfoot>
 			<tbody>
-				<?php
-				$i = 0;
-				foreach ($this->items as $item) : ?>
-				<tr class="row<?php echo $i % 2; ?>">
-					<td>
-						<a class="pointer button-select" href="#" data-user-value="<?php echo $item->id; ?>" data-user-name="<?php echo $this->escape($item->name); ?>"
-							data-user-field="<?php echo $this->escape($field); ?>" <?php if ($isMoo) : ?>onclick="<?php echo $onClick; ?>"<?php endif; ?>>
-							<?php echo $this->escape($item->name); ?>
-						</a>
-					</td>
-					<td>
-						<?php echo $this->escape($item->username); ?>
-					</td>
-					<td class="center">
-						<span class="<?php echo $enabledStates[(int) $this->escape($item->block)]; ?>"></span>
-					</td>
-					<td class="center">
-						<span class="<?php echo $activatedStates[(int) $this->escape($item->activation)]; ?>"></span>
-					</td>
-					<td>
-						<?php echo nl2br($item->group_names); ?>
-					</td>
-					<td>
-						<?php echo (int) $item->id; ?>
-					</td>
-				</tr>
+				<?php $i = 0; ?>
+				<?php foreach ($this->items as $item) : ?>
+					<tr class="row<?php echo $i % 2; ?>">
+						<td>
+							<a class="pointer button-select" href="#" data-user-value="<?php echo $item->id; ?>" data-user-name="<?php echo $this->escape($item->name); ?>"
+								data-user-field="<?php echo $this->escape($field); ?>" <?php if ($isMoo) : ?>onclick="<?php echo $onClick; ?>"<?php endif; ?>>
+								<?php echo $this->escape($item->name); ?>
+							</a>
+						</td>
+						<td>
+							<?php echo $this->escape($item->username); ?>
+						</td>
+						<td class="center">
+							<span class="<?php echo $enabledStates[(int) $this->escape($item->block)]; ?>"></span>
+						</td>
+						<td class="center">
+							<span class="<?php echo $activatedStates[(int) $this->escape($item->activation)]; ?>"></span>
+						</td>
+						<td>
+							<?php echo nl2br($item->group_names); ?>
+						</td>
+						<td>
+							<?php echo (int) $item->id; ?>
+						</td>
+					</tr>
 				<?php endforeach; ?>
 			</tbody>
 		</table>
@@ -123,7 +122,7 @@
 		<input type="hidden" name="field" value="<?php echo $this->escape($field); ?>" />
 		<input type="hidden" name="boxchecked" value="0" />
 		<input type="hidden" name="required" value="<?php echo $userRequired; ?>" />
-		<input type="hidden" name="ismoo" value="<?php echo $input->get('ismoo', 1, 'int'); ?>" />
+		<input type="hidden" name="ismoo" value="<?php echo $isMoo; ?>" />
 		<?php echo JHtml::_('form.token'); ?>
 	</form>
 </div>

From 96e431be059fa87cbbaa383cc6f0aeaa8c9659e3 Mon Sep 17 00:00:00 2001
From: zero-24 <zero-24@users.noreply.github.com>
Date: Mon, 13 Feb 2017 12:18:01 +0100
Subject: [PATCH 2/3] Thanks @joomdonation

---
 administrator/components/com_users/views/users/tmpl/modal.php | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/administrator/components/com_users/views/users/tmpl/modal.php b/administrator/components/com_users/views/users/tmpl/modal.php
index 3882bf6809e97..5231d88bd2bf9 100644
--- a/administrator/components/com_users/views/users/tmpl/modal.php
+++ b/administrator/components/com_users/views/users/tmpl/modal.php
@@ -19,8 +19,7 @@
 $searchFilterDesc = $this->filterForm->getFieldAttribute('search', 'description', null, 'filter');
 JHtml::_('bootstrap.tooltip', '#filter_search', array('title' => JText::_($searchFilterDesc), 'placement' => 'bottom'));
 
-$app             = JFactory::getApplication();
-$input           = $app->input;
+$input           = $input = JFactory::getApplication()->input;
 $field           = $input->getCmd('field');
 $listOrder       = $this->escape($this->state->get('list.ordering'));
 $listDirn        = $this->escape($this->state->get('list.direction'));

From b57b0b7d98316a99030743382c40c29f57d6fb36 Mon Sep 17 00:00:00 2001
From: zero-24 <zero-24@users.noreply.github.com>
Date: Mon, 13 Feb 2017 12:18:26 +0100
Subject: [PATCH 3/3] oops :smile:

---
 administrator/components/com_users/views/users/tmpl/modal.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/administrator/components/com_users/views/users/tmpl/modal.php b/administrator/components/com_users/views/users/tmpl/modal.php
index 5231d88bd2bf9..95cd3f872f3f3 100644
--- a/administrator/components/com_users/views/users/tmpl/modal.php
+++ b/administrator/components/com_users/views/users/tmpl/modal.php
@@ -19,7 +19,7 @@
 $searchFilterDesc = $this->filterForm->getFieldAttribute('search', 'description', null, 'filter');
 JHtml::_('bootstrap.tooltip', '#filter_search', array('title' => JText::_($searchFilterDesc), 'placement' => 'bottom'));
 
-$input           = $input = JFactory::getApplication()->input;
+$input           = JFactory::getApplication()->input;
 $field           = $input->getCmd('field');
 $listOrder       = $this->escape($this->state->get('list.ordering'));
 $listDirn        = $this->escape($this->state->get('list.direction'));