From c8041640eaa3ac046319f5edf037b43470e749a8 Mon Sep 17 00:00:00 2001 From: zero-24 Date: Mon, 26 Feb 2018 23:04:58 +0100 Subject: [PATCH] implement check provided by @ggppdk --- administrator/components/com_admin/models/sysinfo.php | 4 +--- installation/model/setup.php | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/administrator/components/com_admin/models/sysinfo.php b/administrator/components/com_admin/models/sysinfo.php index 6b606e63db373..b08decc9be32a 100644 --- a/administrator/components/com_admin/models/sysinfo.php +++ b/administrator/components/com_admin/models/sysinfo.php @@ -239,8 +239,6 @@ public function &getPhpSettings() return $this->php_settings; } - $outputBuffering = ini_get('output_buffering'); - $this->php_settings = array( 'safe_mode' => ini_get('safe_mode') == '1', 'display_errors' => ini_get('display_errors') == '1', @@ -248,7 +246,7 @@ public function &getPhpSettings() 'file_uploads' => ini_get('file_uploads') == '1', 'magic_quotes_gpc' => ini_get('magic_quotes_gpc') == '1', 'register_globals' => ini_get('register_globals') == '1', - 'output_buffering' => ($outputBuffering === 'On') ? true : is_numeric($outputBuffering), + 'output_buffering' => (int) ini_get('output_buffering') !== 0, 'open_basedir' => ini_get('open_basedir'), 'session.save_path' => ini_get('session.save_path'), 'session.auto_start' => ini_get('session.auto_start'), diff --git a/installation/model/setup.php b/installation/model/setup.php index f4690c6982cca..adfd24a6c967a 100644 --- a/installation/model/setup.php +++ b/installation/model/setup.php @@ -372,10 +372,9 @@ public function getPhpSettings() $settings[] = $setting; // Check for output buffering. - $outputBuffering = ini_get('output_buffering'); $setting = new stdClass; $setting->label = JText::_('INSTL_OUTPUT_BUFFERING'); - $setting->state = ($outputBuffering === 'On') ? true : is_numeric($outputBuffering); + $setting->state = (int) ini_get('output_buffering') !== 0; $setting->recommended = false; $settings[] = $setting;