-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Remove Meta Keywords (part 1) #25258
Conversation
Why do you think we should remove it? Who says it's irrelevant in all cases? Is this true for all search engines or only for google? Our own search engine (smart search) uses the metakey for the ranking... |
https://yoast.com/meta-keywords/ neither yahoo, google or bing use it
As stated in the PR
|
@HLeithner This was also part of the specification for the GSOC 19 SEO project https://docs.google.com/document/d/1MaOtEpp0Ma-e_d7xuXVAnGXP72ec9Ar1XrKtPQvnw4I/edit?usp=sharing |
Adding the rest would be much nicer then removing something thats maybe not used ;-) but ok if george or the other maintainers are happy with it i'm too. |
Yoast is the worst source for "SEO best practice". Rubbish for wordpress newbies. https://yandex.com/support/webmaster/controlling-robot/html.html Meta Tag Keywords are important for SEO in Russia. It is not a problem to use some plugin or some custom fields to obtain this for russian websites. |
@simbus82 i understand this like a candidature to do this work, so please submit a PR or a RFC ....whatever p.s. |
The reason for posting the toast link was to save time posting one link and not three. I am just submitting a pr to match the reques I have no clue on SEO. |
I've edited the yoast url into the PR description so anyone coming to this PR sees it first :) |
We're going to need to document a b/c break to banners if/when we go with this. It seems to filter by the documents keywords. So things like the menu and global config metadata as fallbacks will be relevant there. https://github.com/joomla/joomla-cms/blob/staging/modules/mod_banners/helper.php#L35 In the mean time I'm going to try and ping some people in the Russian community to gain some extra clarification over Yandex |
Re Yandex it does use keywords if this is up to date https://yandex.com/support/webmaster/controlling-robot/html.html |
Getting the following error while applying patch. The file marked for modification does not exist: components/com_search/View/Search/HtmlView.php This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25258. |
I have tested this item 🔴 unsuccessfully on a6409db This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25258. |
Correct me if I am wrong. Updating from J3 to J4 will affect only this - it won't produce a meta key in the frontend? A little poll by me in Russian Telegram chat about keywords states that keywords are 99.9% useless for Yandex. |
Correct |
So do I spend my time updating this pr to resolve the conflicts or not? |
Here is one experience with keywords and Yandex. Quoted and translated from Russian: For a long time I was convinced that keyword is a rudiment, about a year ago I read an article about an experiment where a person added phrases to keywords that were not on the page, and after that he received visibility through them after the time. Believe it or not - this is, as usual in our topic, everyone’s business, but I personally leave it to myself. |
I have tested this item ✅ successfully on 2e575aa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25258. |
1 similar comment
I have tested this item ✅ successfully on 2e575aa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25258. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25258. |
yay!!!! |
@brianteeman Today at 12 UTC: Content language isn't created with the language installation. |
New issue or PR? |
Will work on it. |
Is SQL problem ... will fix it, be patient for new PR. |
@brianteeman Shall the column |
the intention was not to remove the fields in this pr as you will see that the field is still used for mod_related and com_banners |
@brianteeman Thanks for feedback. Yes, noticed that, too, and am in the middle of making PR for allowing empty values in db. am just writing the testing instructions. |
@brianteeman Could you check and test or review or both PR #27854 ? |
* [4.0] Remove Meta Keywords (part 1) Meta Keywords as a meta tag has pretty much been irrelevant for **10 years** This PR does the following 1. Removes Site Meta Keywords from global config 2. Removes Menu item Meta Keywords 3. Removes per language Meta Keywords 4. Renames the item field Meta Keywords to Keywords - We use this as a field with mod_related_items and com_banners Part 2 of removing meta keywords will 1. Move the Keyword field to a more appropriate place 2. Check that all the keyword fields are used with mod_related_items and com_banners ### Testing Check that Meta Keyword field is removed from global config and menu items Check that renamed Keyword field does not produce a meta key in the frontend * . * Update language/en-GB/mod_related_items.sys.ini Co-Authored-By: Quy <quy@fluxbb.org> * Update Content.php * Update Content.php * Update com_banners.ini Co-authored-by: Quy <quy@fluxbb.org>
Meta Keywords as a meta tag has pretty much been irrelevant for 10 years (see https://yoast.com/meta-keywords/ for example)
This PR does the following
Part 2 of removing meta keywords will
Testing
Check that Meta Keyword field is removed from global config and menu items
Check that renamed Keyword field does not produce a meta key in the frontend