Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Backend template #25570

Merged
merged 1,534 commits into from
Aug 15, 2019
Merged

[4.0] Backend template #25570

merged 1,534 commits into from
Aug 15, 2019

Conversation

bembelimen
Copy link
Contributor

@bembelimen bembelimen commented Jul 15, 2019

Summary of Changes

Based on the design from @coolcat-creations and @svom this PR is the next milestone of the backend template "atum" for Joomla! 4. (see first PR here: #21006)

Team members:

@coolcat-creations, @svom, @chmst , @Hackwar, @nadjak77, @fancyFranci, @lavipr, @rdeutz and @karo3

Special thanks to @brianteeman for a lot of valuable feedback and fixes.

New features

  • Rebuild the login layout including a new AJAX login
  • New dashboard functionality: com_cpanel now offers dashboards for every kind of extension where modules can be placed, e.g. com_content: administrator/index.php?option=com_cpanel&view=cpanel&dashboard=content.
  • Improvement of the menu with direkt dashboard and creation links.
  • New quickicons on the main dashboard
  • Filters in list views
  • Improved edit screen
  • Auto-calculation of the template color based on the template parameters
  • extended colorpicker
  • Installation template was updated, too
  • a lot of small improvements

Testing

You can download the nightly of this PR here: https://developer.joomla.org/backend-template/

Extra ping: @wilsonge

bembelimen and others added 30 commits July 11, 2019 17:57
Hide menu items when feature disabled or missing permissions
Edit screen improvement
# Conflicts:
#	.drone.yml
#	administrator/components/com_contact/tmpl/contacts/default.php
#	administrator/components/com_cpanel/Controller/SystemController.php
#	administrator/components/com_cpanel/tmpl/cpanel/default.php
#	administrator/components/com_fields/View/Fields/HtmlView.php
#	administrator/components/com_modules/tmpl/module/edit.php
#	administrator/components/com_users/View/Notes/HtmlView.php
#	administrator/components/com_users/View/Users/HtmlView.php
#	composer.lock
missing ? in the ternerary
Done in this repo to make it easier so you dont edit files that we dont use
Change the capitalisation of these new strings so they match the codestyle
Updating release to latest 4.0-dev from main repo
Remove unused files from the tmpl
@infograf768
Copy link
Member

infograf768 commented Aug 12, 2019

@infograf768 "UI is broken depending on screen size": Isn't that the case with current 4.0-dev, too?

Nope.

PLEASE only report issues here that are specific to this template. IE if it doesn't work without this PR applied either then report it as its own issue

It IS specific to this PR! Testing before posting is helpful.

This is what we get for the current template: we do NOT have this issue:

Screen Shot 2019-08-12 at 08 14 31

EDIT: Issue comes from css

.options-grid-form > div {
    grid-template-columns: 1fr 1fr 1fr;
}

When it should be

.options-grid-form > div {
    grid-template-columns: 1fr 1fr;
}

EDIT:
Solution is to add a class (here for itemadmin_component.xml, did not test with all menu items xml but looks similar for alias, heading, separator, url). As done for site menu items.

	<fields name="params" label="COM_MENUS_LINKTYPE_OPTIONS_LABEL">
		<fieldset name="menu-options"
			label="COM_MENUS_LINKTYPE_OPTIONS_LABEL"
			class="options-grid-form-half"
		>

@Scrabble96
Copy link
Contributor

Good to have the 'real' name requested when installing Joomla, but could this say 'display name' instead?

@richard67
Copy link
Member

richard67 commented Aug 13, 2019

@Scrabble96 The "real name" to be entered at installation has nothing to do with the new template and so nothing to do with this PR. It was a change made in 4.0-dev with Pull Request (PR) #25774 and came to the backend template by merging in latest 4.0-dev changes. So if you like to change that, make a new issue for 4.0-dev branch. But if it shall be changed, it should be changed everyhwre. Up to now I don't remeber having seen the term "display name" anywhere in J4 for the user name, so using this only at installation would be inconsistent with J4 after installation.

@wilsonge
Copy link
Contributor

Thank you everyone who was involved here. @ciar4n i'm working on your sass changes at the moment and will do a PR to fix them over the next day or so (unfortunately a bit swamped with real life work at the moment). I know there are some issues raised in here that still aren't fixed but I don't believe these issues to be blocking the merge at this time either so that we have the unified code base and more people can explore and contribute towards this template.

I'd also like to reiterate the below comment I made

We are aware that once this is merged more people will be testing it and new issues will be discovered. That doesn't mean it's buggy or poor quality - it's just an acknowledgement that this was and still is a huge task and it's not possible for a small group of people to test, discover and fix everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.