-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] State dropdown fixes #29269
[4.0] State dropdown fixes #29269
Conversation
Fix state dropdown color
@@ -60,7 +60,7 @@ | |||
label="JSTATUS" | |||
class="custom-select-color-state" | |||
size="1" | |||
default="1" | |||
default="0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In J3, it defaults to published. OK to change in J4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the default status of an item when created should be refactored globally. It's very inconsistent in the system. Sometime it's published, sometime it's not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC in J3 creating a new item is always published. creating a copy of an item is always unpublished
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps move this change into its own PR.
This fixes #29452 styling issue, When you decide with "default state" I will mark it as "test ok" :) |
I have tested this item ✅ successfully on d26c135 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29269. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29269. |
@Quy RTC With 1 test? Do we have new rules? 😛 |
and Fedik. |
@Quy Yes, just saw his comment. |
I have tested this item ✅ successfully on d26c135 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29269. |
@Fedik I am German, I need correct statistics ;-) P.S.: And it looks so nice when all is green at the bottom of a PR. |
Thanks all! |
Pull Request for Issue #29235 (comment) .
Summary of Changes
Fix the state value color and the default value for frontend article view.
Testing Instructions
Disable the workflow and create a new article in the frontend (with core.edit.state permissions)
Expected result
Actual result