Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] State dropdown fixes #29269

Merged
merged 5 commits into from
Jun 6, 2020
Merged

Conversation

bembelimen
Copy link
Contributor

Pull Request for Issue #29235 (comment) .

Summary of Changes

Fix the state value color and the default value for frontend article view.

Testing Instructions

Disable the workflow and create a new article in the frontend (with core.edit.state permissions)

Expected result

grafik

grafik

Actual result

grafik

grafik

@@ -60,7 +60,7 @@
label="JSTATUS"
class="custom-select-color-state"
size="1"
default="1"
default="0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In J3, it defaults to published. OK to change in J4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the default status of an item when created should be refactored globally. It's very inconsistent in the system. Sometime it's published, sometime it's not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC in J3 creating a new item is always published. creating a copy of an item is always unpublished

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move this change into its own PR.

@Fedik
Copy link
Member

Fedik commented Jun 6, 2020

This fixes #29452 styling issue,

When you decide with "default state" I will mark it as "test ok" :)

@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Jun 6, 2020
@Quy
Copy link
Contributor

Quy commented Jun 6, 2020

I have tested this item ✅ successfully on d26c135


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29269.

@Quy Quy added Information Required and removed NPM Resource Changed This Pull Request can't be tested by Patchtester labels Jun 6, 2020
@Quy
Copy link
Contributor

Quy commented Jun 6, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29269.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 6, 2020
@richard67
Copy link
Member

@Quy RTC With 1 test? Do we have new rules? 😛

@Quy
Copy link
Contributor

Quy commented Jun 6, 2020

and Fedik.

@richard67
Copy link
Member

@Quy Yes, just saw his comment.

@Fedik
Copy link
Member

Fedik commented Jun 6, 2020

I have tested this item ✅ successfully on d26c135

to be sure (:


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29269.

@richard67
Copy link
Member

richard67 commented Jun 6, 2020

@Fedik I am German, I need correct statistics ;-)

P.S.: And it looks so nice when all is green at the bottom of a PR.

@richard67 richard67 merged commit 0f6a150 into joomla:4.0-dev Jun 6, 2020
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Jun 6, 2020
@richard67
Copy link
Member

Thanks all!

@richard67 richard67 added this to the Joomla 4.0 milestone Jun 6, 2020
@bembelimen bembelimen deleted the state-dropdown-layout branch March 15, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Information Required NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants