Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] State dropdown fixes #29269

Merged
merged 5 commits into from
Jun 6, 2020
Merged

[4.0] State dropdown fixes #29269

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51dc217
Set default state value to 0
bembelimen May 30, 2020
2952f6a
Set dropdown color to green/red
bembelimen May 30, 2020
328e7e4
Fix spacing
bembelimen May 30, 2020
5a1f707
Fix wrong css code
bembelimen May 30, 2020
d26c135
Revert default state
bembelimen Jun 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/com_content/forms/article.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
label="JSTATUS"
class="custom-select-color-state"
size="1"
default="1"
default="0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In J3, it defaults to published. OK to change in J4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the default status of an item when created should be refactored globally. It's very inconsistent in the system. Sometime it's published, sometime it's not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC in J3 creating a new item is always published. creating a copy of an item is always unpublished

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move this change into its own PR.

>
<option value="1">JPUBLISHED</option>
<option value="0">JUNPUBLISHED</option>
Expand Down
4 changes: 2 additions & 2 deletions templates/cassiopeia/scss/vendor/bootstrap/_custom-forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
&.custom-select-color-state {

&.custom-select-success {
color: $white-offset;
color: theme-color("success");
background-color: theme-color("success");

option {
Expand All @@ -43,7 +43,7 @@
}

&.custom-select-danger {
color: $white-offset;
color: theme-color("danger");
background-color: theme-color("danger");

option {
Expand Down