[4.0] Fix mod_articles_latest

[chmst]

Pull Request for Issue #30445 .

Summary of Changes

Add a filter.condition for published articles to mod_articles_latest.

Testing Instructions

See the related #30445 .

Actual result BEFORE applying this Pull Request

Unpublished articles are shown in the Module mod_articles_latest.

Expected result AFTER applying this Pull Request

Only published articles are shown in the Module mod_articles_latest.

Documentation Changes Required

no

[SharkyKZ]

Is there any reason why state/condition filter is called filter.published in backend and filter.condition in backend?

[chmst]

@SharkyKZ I don't know. The filter should have the same name as in J3.x for 3rd party extensions. This is a quick fix for the issue.

[paternax]

It works like it should with this patch

[sandewt]

I have tested this item ✅ successfully on c1498f4

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT

See comment.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.}

[richard67]

It works like it should with this patch

@paternax Does it mean you have tested this pull resuest with success? If so, could you mark your test result on the issue tracker? Just follow this link https://issues.joomla.org/tracker/joomla-cms/30459 and then use the "Test this" button. Then select your appropriate test result ("succes" in this case) and submitt. Thanks in advance.

[sandewt]

Is there any reason why state/condition filter is called filter.published in backend and filter.condition in backend?

$model->setState('filter.published', 1) DOESN'T WORK !

This following code works as alternative for: $model->setState('filter.condition', 1);

use Joomla\Component\Content\Administrator\Extension\ContentComponent;
...
$model->setState('filter.condition', ContentComponent::CONDITION_PUBLISHED);

[EDIT]

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.}

[SharkyKZ]

@chmst So it should be filter.published. I guess #29235 just forgot to make replacements in frontend models. Maybe @bembelimen or @HLeithner knows.

[chmst]

Then it would be good th have this merged soon. And make complete change for the filter name.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.}

[HLeithner]

Yes seems like we oversee this, it should be filter.published iirc there should be no condition keyword more in frontend.

[paternax]

I have tested this item ✅ successfully on c1498f4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.}

[richard67]

@HLeithner So this one here is ok so far, and the rest can be fixed with a new PR?

@chmst Can you do that?

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.}

[chmst]

@richard67 I'll prepare a PR for that

[wilsonge]

Merging this one as above then. Thanks!