Fix call_user_func_array() arguments on PHP 8 #30608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
approved these changes
Sep 17, 2020
|
unable to replicate on PHP Version 8.0.0-dev |
|
@alikon How recent is your PHP build? I'm using Beta 4. |
|
my php images is based on https://github.com/devilbox/docker-php-fpm-8.0 |
|
Just tried with RC1. Issue still exists. |
3 tasks
|
I have tested this item ✅ successfully on 4ca4641 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30608. |
|
Tested successfully, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Changes second argument of
call_user_func_array()from associative to indexed array. Before PHP 8 both types of arrays work the same but on PHP 8 associative arrays are interpreted as "named parameters". In our case this causes code to break.Testing Instructions
Use PHP 8.
Open article form.
Actual result BEFORE applying this Pull Request
Error:
Expected result AFTER applying this Pull Request
No errors, editor and editor buttons appear correctly.
Documentation Changes Required
No.