From 0c0a30f5de537e3123498ea5522e8708d15818d9 Mon Sep 17 00:00:00 2001 From: kanich Date: Fri, 14 Feb 2014 10:46:18 +0100 Subject: [PATCH 1/4] Proposed onAfterRenderModules event in modules rendering During development and usage of JotCache extension (#13155 on JED) was found that exclusion and dynamic restore of modules during page caching requires processing inside core modules.php code. The best way is to trigger event on the end of template position modules rendering and process all necessary operations in plugin. Proposed patch is working in JotCache 4.1.0 for J3.2 using class overlay. --- libraries/joomla/document/html/renderer/modules.php | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/joomla/document/html/renderer/modules.php b/libraries/joomla/document/html/renderer/modules.php index bbbaa6785efac..4a10dd1dce6d4 100644 --- a/libraries/joomla/document/html/renderer/modules.php +++ b/libraries/joomla/document/html/renderer/modules.php @@ -54,6 +54,7 @@ public function render($position, $params = array(), $content = null) $buffer .= $moduleHtml; } + JDispatcher::getInstance()->trigger('onAfterRenderModules', array(&$buffer, &$params)); return $buffer; } } From eb7a0c78ce03406b77395d429069c0dd9f73687e Mon Sep 17 00:00:00 2001 From: kanich Date: Thu, 27 Mar 2014 05:58:06 +0100 Subject: [PATCH 2/4] Update modules.php Using JEventDispatcher instead of depreciated JDispatcher class --- libraries/joomla/document/html/renderer/modules.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/joomla/document/html/renderer/modules.php b/libraries/joomla/document/html/renderer/modules.php index 4a10dd1dce6d4..969fb55b20b28 100644 --- a/libraries/joomla/document/html/renderer/modules.php +++ b/libraries/joomla/document/html/renderer/modules.php @@ -54,7 +54,7 @@ public function render($position, $params = array(), $content = null) $buffer .= $moduleHtml; } - JDispatcher::getInstance()->trigger('onAfterRenderModules', array(&$buffer, &$params)); + JEventDispatcher::getInstance()->trigger('onAfterRenderModules', array(&$buffer, &$params)); return $buffer; } } From fc26db402d0093565eba4a1e4f86b884f2b60dd6 Mon Sep 17 00:00:00 2001 From: kanich Date: Fri, 3 Apr 2015 14:45:58 +0200 Subject: [PATCH 3/4] Update modules.php --- libraries/joomla/document/html/renderer/modules.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/joomla/document/html/renderer/modules.php b/libraries/joomla/document/html/renderer/modules.php index 969fb55b20b28..f1aa956f4fe15 100644 --- a/libraries/joomla/document/html/renderer/modules.php +++ b/libraries/joomla/document/html/renderer/modules.php @@ -54,7 +54,7 @@ public function render($position, $params = array(), $content = null) $buffer .= $moduleHtml; } - JEventDispatcher::getInstance()->trigger('onAfterRenderModules', array(&$buffer, &$params)); + JEventDispatcher::getInstance()->trigger('onAfterRenderModules', array(&$buffer, &$params)); return $buffer; } } From a117efbd8b4d5170e2ed387cb89fd228327483b2 Mon Sep 17 00:00:00 2001 From: kanich Date: Mon, 9 Nov 2015 09:22:03 +0100 Subject: [PATCH 4/4] Update modules.php Added the clean line between line 57 and 58 for CS (as requested). --- libraries/joomla/document/html/renderer/modules.php | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/joomla/document/html/renderer/modules.php b/libraries/joomla/document/html/renderer/modules.php index f1aa956f4fe15..6cfc8927c7d90 100644 --- a/libraries/joomla/document/html/renderer/modules.php +++ b/libraries/joomla/document/html/renderer/modules.php @@ -55,6 +55,7 @@ public function render($position, $params = array(), $content = null) } JEventDispatcher::getInstance()->trigger('onAfterRenderModules', array(&$buffer, &$params)); + return $buffer; } }