Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Adminmenu: Fix export for child items #43178

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 28, 2024

Pull Request for Issue #37273 .

Summary of Changes

When exporting a menu preset in J4, the information about the tree of the menu items gets lost. This fixes that.

Testing Instructions

  1. Go to menu manager, filter by admin and create a new menu for the administrator. Make sure to select a preset to pre-populate the menu.
  2. In the menu manager, select the menu and click "Download as Preset"

Actual result BEFORE applying this Pull Request

You get a XML in return and all <menuitem> tags are on the same level.

Expected result AFTER applying this Pull Request

The menuitem tags are nested properly in the way they are in the menu tree.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on a4eb988


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43178.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Mar 28, 2024

I have tested this item ✅ successfully on a4eb988


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43178.

@Quy Quy added the bug label Mar 28, 2024
@Quy
Copy link
Contributor

Quy commented Mar 28, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43178.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 28, 2024
@MacJoom MacJoom self-assigned this Apr 27, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.5 milestone Apr 27, 2024
@MacJoom MacJoom merged commit 27ffec3 into joomla:4.4-dev Apr 27, 2024
3 checks passed
@MacJoom
Copy link
Contributor

MacJoom commented Apr 27, 2024

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants