-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Form Text Field: Translate text for frontend validation #43198
Conversation
The way to set the |
That might be, however that would be a refactoring and a new feature, which we can only really do in a major or minor release, not in a patch release. Fixing the bug for now however would be possible for 4.4, which means people on 4.4 and 5.1 would both benefit from this now instead of having to wait for 5.2. |
I'm not sure what's the new feature here. All I said is that instead changing this in the layout you should doit in the form class. The same conditional, essentially the same code, but in the right place using the existing API for the data. |
I have tested this item ✅ successfully on ebd2d9f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198. |
I have tested this item ✅ successfully on ebd2d9f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198. |
I have tested this item 🔴 unsuccessfully on ebd2d9f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198. |
changed my test result as it needs to be escaped as Fedir pointed out. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198. |
@Quy @brianteeman I escaped the string. Would you be able to test this again? |
I have tested this item ✅ successfully on 8baa931 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198. |
1 similar comment
I have tested this item ✅ successfully on 8baa931 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198. |
Thanks! |
…#43198) * Form Text Field: Translate text for frontend validation * Update text.php --------- Co-authored-by: Quy <quy@nomonkeybiz.com>
…#43198) * Form Text Field: Translate text for frontend validation * Update text.php --------- Co-authored-by: Quy <quy@nomonkeybiz.com>
Pull Request for Issue #42919 .
Summary of Changes
The validation text for frontend validation right now is not translated.
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed