Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Languagefilter: Add message when no content language is published #43232

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 8, 2024

Pull Request for Issue #41798 .

Summary of Changes

When you unpublish all content languages, but have the languagefilter system plugin enabled, the system is in an undefined state and different errors can show up. This PR adds a constant message to all pages that the administrator has to take action here.

Testing Instructions

  1. Unpublish all content languages
  2. Enable the languagefilter plugin

Actual result BEFORE applying this Pull Request

See nothing, maybe PHP notices from the languagefilter plugin.

Expected result AFTER applying this Pull Request

See a message that the content languages are disabled and the languagefilter plugin is enabled.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Apr 8, 2024

I have tested this item ✅ successfully on 4e5629b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43232.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 4e5629b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43232.

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@Quy
Copy link
Contributor

Quy commented Apr 21, 2024

I have tested this item ✅ successfully on 352b86f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43232.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 352b86f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43232.

@Quy
Copy link
Contributor

Quy commented Apr 21, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43232.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 21, 2024
@woluweb woluweb merged commit 04548a2 into joomla:5.2-dev Apr 23, 2024
0 of 2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 23, 2024
@woluweb
Copy link
Contributor

woluweb commented Apr 23, 2024

txs @Hackwar!

@Quy Quy added this to the Joomla! 5.2.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants