Skip to content

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Dec 6, 2024

Summary of Changes

Adds override compare functionality to plugin overrides

Testing Instructions

In the template manager create an override for any plugin
Select one of the files in the override

Actual result BEFORE applying this Pull Request

Show Original File and Show Differences not present

image

Expected result AFTER applying this Pull Request

Show Original File and Show Differences are present and you can se the differences etc

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <brian@teeman.net>
Signed-off-by: BrianTeeman <brian@teeman.net>
@ghost
Copy link

ghost commented Dec 7, 2024

I have tested this item ✅ successfully on ab53b22


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44588.

Signed-off-by: BrianTeeman <brian@teeman.net>
@richard67
Copy link
Member

I've restored @fgsw 's test result in the issue tracker and have set the test result for @Quy as he can't do that currently so asked in Mattermost to do that.

=> RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44588.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 7, 2024
@HLeithner HLeithner merged commit 14a4be8 into joomla:5.3-dev Dec 8, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 8, 2024
@HLeithner
Copy link
Member

slightly related is the wrong type usage for array access $explodeArray['1'] casts in implizit type conversation to integer which is not correct here. So if someone likes to fix this please go ahead.

@brianteeman brianteeman deleted the plugin_override branch December 8, 2024 10:29
@rdeutz rdeutz added this to the Joomla! 5.3.0 milestone Dec 24, 2024
@sdwjoomla sdwjoomla mentioned this pull request Feb 13, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants