-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.4] allow Redis min server port =0 #46396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.4-dev
Are you sure you want to change the base?
Conversation
|
What happens if you enter zero in the form and a server which is not a path to a socket but just a hostname and save? Just am curious. |
|
if you need to change the port to zero you probably already know what you are doing and why, there is already a default that works well for the majority of setups, right now you cannot use port zero as for xml, that's all |
@alikon Yes, that's ok, and I do not want to question this PR. I just was curious on what would happen, and maybe someone can test that. |
|
on a standard setup i mean port 6379 (default) if you set zero as port you are not able to connect to the redis server, nothing different than before, this pr just allow to use port zero when you know why and when to do it |
|
Is it too much to hide the port field if the connection url is a file ending in .sock? or we overdoing it? |
|
subject for another pull request |
Pull Request for Issue #46162 .
Summary of Changes
set min value =0 for redis server port
Testing Instructions
see #46162
Actual result BEFORE applying this Pull Request
Invalid field: Redis server port
Expected result AFTER applying this Pull Request
redis connect
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed