[6.0] Fix deprecated message in messages - my settings

[chmst]

Pull Request for Issue #
see https://forum.joomla.de/thread/23070-e-mail-benachrichtigung-bei-neuen-nachrichten/?postID=176266#post176266

Note: The issue does not exist in 5.4.

Summary of Changes

Define $item as \stdClass().

Testing Instructions

On a J6.0 with PHP 8.3 or 8.4 set debug-modus on and error-reporting to "maximum"
Go to Users - messages - private messaging, Click the Settings-Button top left.

Actual result BEFORE applying this Pull Request

Change Settings, new Settings are not stored.

Expected result AFTER applying this Pull Request

No deprecated messages, Settings are stored correctly

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[ChristineWk]

I have tested this item ✅ successfully on a875028

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46475.}

[CMS-Manufaktur]

I have tested this item ✅ successfully on a875028

Test after modifying the file was successful. The error messages disappear and the settings are saved.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46475.}

[richard67]

System tests are failing. All failures belong to test script site/components/com_privacy/Request.cy.js and are related to privacy requests.

[ChristineWk]

I have tested this item ✅ successfully on 6be0cec

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46475.}

[richard67]

System tests are still failing, same issue as before the last commit.

[chmst]

I see

[CMS-Manufaktur]

I have tested this item ✅ successfully on 6be0cec

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46475.}

[chmst]

Converted to draft due to failing system tests.

[chmst]

As all checks have passed, may I ask you for a new test, @ChristineWk and @CMS-Manufaktur? Thank you for your patience. And Thank you @LadySolveig and @bembelimen.

[ChristineWk]

I have tested this item ✅ successfully on d86bd12

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46475.}

[exlemor]

I have tested this item ✅ successfully on d86bd12

I have tested this successfully, Thank you @chmst!

To be clear, 2 situations have been detected and corrected with this PR:

1. you must make some changes to the toggles: My Settings -> Lock Inbox and/or Email New Messages and/or Auto-delete Messages settings AND press Save and Close so that the database has some data in it BEFORE you see the Deprecated messages

2. the settings BEFORE the PR are not saved.

After the PR, both the Deprecated messages AND the settings are saved correctly.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46475.}

[muhme]

I have tested this item ✅ successfully on d86bd12

Tested with JBT

• Seen before the PR the deprecations and the values are not saved
• Applied the PR with Patch Tester and no more deprecations and values are saved

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46475.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46475.}