Skip to content

[5.3] Awesomplete accessibility fix #3392

@jgerman-bot

Description

@jgerman-bot

New language relevant PR in upstream repo: joomla/joomla-cms#44756 Here are the upstream changes:

Click to expand the diff!
diff --git a/build/media_source/com_finder/js/finder.es6.js b/build/media_source/com_finder/js/finder.es6.js
index 62ff50fcb7d60..21d402470ec24 100644
--- a/build/media_source/com_finder/js/finder.es6.js
+++ b/build/media_source/com_finder/js/finder.es6.js
@@ -69,7 +69,7 @@
     document.querySelectorAll('.js-finder-search-query').forEach((searchword) => {
       // Handle the auto suggestion
       if (Joomla.getOptions('finder-search')) {
-        searchword.awesomplete = new Awesomplete(searchword);
+        searchword.awesomplete = new Awesomplete(searchword, { listLabel: Joomla.Text._('COM_FINDER_SEARCH_FORM_LIST_LABEL') });
 
         // If the current value is empty, set the previous value.
         searchword.addEventListener('input', onInputChange);
diff --git a/components/com_finder/tmpl/search/default_form.php b/components/com_finder/tmpl/search/default_form.php
index d4001ac5d4bcd..c6130453e5852 100644
--- a/components/com_finder/tmpl/search/default_form.php
+++ b/components/com_finder/tmpl/search/default_form.php
@@ -22,6 +22,7 @@
     $this->getDocument()->getWebAssetManager()->usePreset('awesomplete');
     $this->getDocument()->addScriptOptions('finder-search', ['url' => Route::_('index.php?option=com_finder&task=suggestions.suggest&format=json&tmpl=component', false)]);
 
+    Text::script('COM_FINDER_SEARCH_FORM_LIST_LABEL');
     Text::script('JLIB_JS_AJAX_ERROR_OTHER');
     Text::script('JLIB_JS_AJAX_ERROR_PARSE');
 }
diff --git a/language/en-GB/com_finder.ini b/language/en-GB/com_finder.ini
index dd727eff73845..9aabb1c9df587 100644
--- a/language/en-GB/com_finder.ini
+++ b/language/en-GB/com_finder.ini
@@ -45,6 +45,7 @@ COM_FINDER_QUERY_TOKEN_OPTIONAL="<span class=\"term\">%s</span> is optional"
 COM_FINDER_QUERY_TOKEN_REQUIRED="<span class=\"term\">%s</span> is required"
 COM_FINDER_SEARCH_ADVANCED_LEGEND="Advanced Search"
 COM_FINDER_SEARCH_FORM_LEGEND="Search Form"
+COM_FINDER_SEARCH_FORM_LIST_LABEL="Search Results"
 COM_FINDER_SEARCH_NO_RESULTS_BODY="No search results could be found for query: %s."
 COM_FINDER_SEARCH_NO_RESULTS_BODY_MULTILANG="No search results in English (en-GB) could be found for query: %s."
 COM_FINDER_SEARCH_NO_RESULTS_HEADING="No Results Found"
diff --git a/modules/mod_finder/tmpl/default.php b/modules/mod_finder/tmpl/default.php
index dcde897991376..b1bcbdd9a2ad1 100644
--- a/modules/mod_finder/tmpl/default.php
+++ b/modules/mod_finder/tmpl/default.php
@@ -52,6 +52,7 @@
     $wa->usePreset('awesomplete');
     $app->getDocument()->addScriptOptions('finder-search', ['url' => Route::_('index.php?option=com_finder&task=suggestions.suggest&format=json&tmpl=component', false)]);
 
+    Text::script('COM_FINDER_SEARCH_FORM_LIST_LABEL');
     Text::script('JLIB_JS_AJAX_ERROR_OTHER');
     Text::script('JLIB_JS_AJAX_ERROR_PARSE');
 }

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions