Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Created translatable strings for LocalAdapter.php "code review" #3290

Merged
merged 8 commits into from
Oct 7, 2024

Conversation

tecpromotion
Copy link
Member

@tecpromotion tecpromotion commented Sep 20, 2024

Pull Request für Issue #3286 .

Zusammenfassung der Änderungen

add new strings

  • translation

Wo wird der Sprachstring angezeigt / Wie kann getestet werden

backend
frontend

Sorry, something went wrong.

translation
@tecpromotion tecpromotion marked this pull request as ready for review September 24, 2024 15:56
@tecpromotion tecpromotion requested review from a team, zero-24 and heelc29 and removed request for a team September 24, 2024 15:56
Copy link
Member

@zero-24 zero-24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, so in dem style vielleicht etwas expliziter also anstatt Zieldatei Datei mit dem Namen?

Müsste dann auch noch an den anderen Stellen angepasst werden

administrator/language/de-DE/com_media.ini Outdated Show resolved Hide resolved
administrator/language/de-DE/com_media.ini Outdated Show resolved Hide resolved
tecpromotion and others added 2 commits October 1, 2024 21:06
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
@tecpromotion tecpromotion requested a review from zero-24 October 1, 2024 19:06
@zero-24
Copy link
Member

zero-24 commented Oct 2, 2024

Wenn wir meinen Vorschlag nehmen müssten wir auch noch die anderen Strings nachziehen, schaffe ich aber heute nicht mehr da ich noch unterwegs bin

@tecpromotion
Copy link
Member Author

Wenn wir meinen Vorschlag nehmen müssten wir auch noch die anderen Strings nachziehen, schaffe ich aber heute nicht mehr da ich noch unterwegs bin

Kann ich machen.

@zero-24
Copy link
Member

zero-24 commented Oct 7, 2024

Merging thanks @tecpromotion 👍

@zero-24 zero-24 merged commit 95af477 into joomlagerman:5.2-dev Oct 7, 2024
@zero-24 zero-24 deleted the issue-3286 branch October 7, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[5.2] Created translatable strings for LocalAdapter.php "code review"
2 participants