WIP suggestion for #238 #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@naugtur Can you modify this PR's title? How do you want to name this feature? 😄 I have a few other questions:
|
|
This is an old proposal and seeing the thread with Components evolve so much, I want to push it in a simpler direction. I'll rename some things as I go. |
|
@naugtur Awesome thanks! |
|
@naugtur What's up! I think I'd prefer to close here and leave it up to you to reopen/create a new PR when the time is right. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't exactly like where #238 was going with components looking like more hperapp apps with separate state and actions.
I've built something that's similar to how redux-react does single source of truth.
Actions would stay on the main app along with the state they're modifying.
The only issue I think has to be fixed before this is viable is finding a better place to put context in. It has to be rooted in the app, but I didn't find the right place yet. It'd probably eliminate the need to have Provider at all.
see
/pocfor usage example.