fix: [nautilus-cyberneering#197] replace regexp by external pakckage …

…for email valitation The new validator is more restrict.
josecelano · Jun 8, 2022 · 1146953 · 1146953
1 parent db0f52e
commit 1146953
Show file tree

Hide file tree

Showing 5 changed files with 107 additions and 19 deletions.
diff --git a/__tests__/unit/email-address.test.ts b/__tests__/unit/email-address.test.ts
@@ -32,20 +32,9 @@ describe('EmailAddress', () => {
  it('should validate email addresses', () => {
  const validEmails = [
  'Abc@example.com',
- 'Abc@example.com.',
- 'Abc@10.42.0.1',
- 'user@localserver',
  'Abc.123@example.com',
  'user+mailbox/department=shipping@example.com',
- '"very.(),:;<>[]".VERY."very@\\ "very".unusual"@strange.example.com',
- "!#$%&'*+-/=?^_`.{|}~@example.com",
- '"()<>[]:,;@\\"!#$%&\'-/=?^_`{}| ~.a"@example.org',
- '"Abc@def"@example.com',
- '"Fred Bloggs"@example.com',
- '"Joe.\\Blow"@example.com',
- 'Loïc.Accentué@voilà.fr',
- 'user@[IPv6:2001:DB8::1]',
- '" "@example.org'
+ "!#$%&'*+-/=?^_`.{|}~@example.com"
  ]
 
  for (const email of validEmails) {
@@ -59,7 +48,18 @@ describe('EmailAddress', () => {
  'this is"notallowed@example.com',
  'this still"not\\allowed@example.com',
  'john..doe@example.com',
- 'john.doe@example..com'
+ 'john.doe@example..com',
+ 'Abc@example.com.',
+ 'Abc@10.42.0.1',
+ 'user@localserver',
+ '"very.(),:;<>[]".VERY."very@\\ "very".unusual"@strange.example.com',
+ '"()<>[]:,;@\\"!#$%&\'-/=?^_`{}| ~.a"@example.org',
+ '"Abc@def"@example.com',
+ '"Fred Bloggs"@example.com',
+ '"Joe.\\Blow"@example.com',
+ 'Loïc.Accentué@voilà.fr',
+ 'user@[IPv6:2001:DB8::1]',
+ '" "@example.org'
  ]
 
  for (const email of invalidEmails) {

diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/dist/licenses.txt b/dist/licenses.txt
diff --git a/src/email-address.ts b/src/email-address.ts
@@ -1,3 +1,5 @@
+import * as EmailValidator from 'email-validator'
+
 /*
  * Wrapper for RFC5322 email address.
  *
@@ -85,7 +87,5 @@ export class EmailAddress {
 }
 
 export function emailIsValid(email: string): boolean {
- return /^(([^<>()[\].,;:\s@"]+(\.[^<>()[\].,;:\s@"]+)*)|(".+"))@(([^<>().,;\s@"]+\.{0,1})+([^<>().,;:\s@"]{2,}|[\d.]+))$/.test(
- email
- )
+ return EmailValidator.validate(email)
 }