fix: needless borrow on actions and paket modules

joseluisq · Nov 6, 2022 · 81ce386 · 81ce386
1 parent e2cf0db
commit 81ce386
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/cli/actions.rs b/src/cli/actions.rs
@@ -53,7 +53,7 @@ impl<'a> Actions<'a> {
             // Clone the remote repository
             self.git.clone(pkg_name, pkg_tag, git_provider)?;
 
-            let pkg_dir = self.git.base_dir.join(&pkg_name);
+            let pkg_dir = self.git.base_dir.join(pkg_name);
             if !self.paket.pkg_exists(pkg_name) {
                 bail!("package `{}` was not cloned with success.", pkg_name);
             }
@@ -120,7 +120,7 @@ impl<'a> Actions<'a> {
 
             self.git
                 .base_dir
-                .join(&pkg_name)
+                .join(pkg_name)
                 .canonicalize()
                 .with_context(|| format!("package `{}` was not updated properly.", pkg_name))?
         };
@@ -172,7 +172,7 @@ impl<'a> Actions<'a> {
             println!("Uninstalling package `{}`...", &pkg_name);
 
             // Process Fish shell package structure
-            let pkg_dir = self.git.base_dir.join(&pkg_name);
+            let pkg_dir = self.git.base_dir.join(pkg_name);
             if !self.paket.pkg_exists(pkg_name) {
                 bail!(
                     "package `{}` is not installed or was already removed.",

diff --git a/src/paket.rs b/src/paket.rs
@@ -245,7 +245,7 @@ impl<'a> Paket {
 
                 // Check for files with allowed directory parents
                 if let Some(parent) = path.parent() {
-                    if !helper_file::has_path_any_suffixes(&parent, &path_suffixes) {
+                    if !helper_file::has_path_any_suffixes(parent, &path_suffixes) {
                         continue;
                     }