diff --git a/CHANGELOG-3.1.md b/CHANGELOG-3.1.md index d362ae1595d..5856e5e95f7 100644 --- a/CHANGELOG-3.1.md +++ b/CHANGELOG-3.1.md @@ -8,6 +8,13 @@ The [minimum recommended etcd versions to run in **production**](https://groups.
+## [v3.1.21](https://github.com/etcd-io/etcd/releases/tag/v3.1.21) (2019-TBD) + +### etcdctl + +- [Strip out insecure endpoints from DNS SRV records when using discovery](https://github.com/etcd-io/etcd/pull/10443) with etcdctl v2 + +
## [v3.1.20](https://github.com/etcd-io/etcd/releases/tag/v3.1.20) (2018-10-10) diff --git a/CHANGELOG-3.2.md b/CHANGELOG-3.2.md index 588201b08d5..c0832aded71 100644 --- a/CHANGELOG-3.2.md +++ b/CHANGELOG-3.2.md @@ -11,6 +11,9 @@ The [minimum recommended etcd versions to run in **production**](https://groups. ## [v3.2.27](https://github.com/etcd-io/etcd/releases/tag/v3.2.27) (2019-TBD) +### etcdctl + +- [Strip out insecure endpoints from DNS SRV records when using discovery](https://github.com/etcd-io/etcd/pull/10443) with etcdctl v2
diff --git a/CHANGELOG-3.4.md b/CHANGELOG-3.4.md index 73bb87dbfaa..21bd01208fe 100644 --- a/CHANGELOG-3.4.md +++ b/CHANGELOG-3.4.md @@ -429,6 +429,7 @@ Note: **v3.5 will deprecate `etcd --log-package-levels` flag for `capnslog`**; ` save`. - User can specify timeout of `etcdctl snapshot save` command using flag `--command-timeout`. + - Fix etcdctl to [strip out insecure endpoints from DNS SRV records when using discovery](https://github.com/etcd-io/etcd/pull/10443) ### gRPC proxy diff --git a/etcdctl/ctlv2/command/util.go b/etcdctl/ctlv2/command/util.go index d19cd40e384..c178abd9da2 100644 --- a/etcdctl/ctlv2/command/util.go +++ b/etcdctl/ctlv2/command/util.go @@ -104,7 +104,7 @@ func getDomainDiscoveryFlagValue(c *cli.Context) ([]string, error) { // strip insecure connections ret := []string{} for _, ep := range eps { - if strings.HasPrefix("http://", ep) { + if strings.HasPrefix(ep, "http://") { fmt.Fprintf(os.Stderr, "ignoring discovered insecure endpoint %q\n", ep) continue } diff --git a/etcdctl/ctlv3/command/global.go b/etcdctl/ctlv3/command/global.go index eb90f2a4fac..49a22037983 100644 --- a/etcdctl/ctlv3/command/global.go +++ b/etcdctl/ctlv3/command/global.go @@ -444,7 +444,7 @@ func endpointsFromFlagValue(cmd *cobra.Command) ([]string, error) { // strip insecure connections ret := []string{} for _, ep := range eps { - if strings.HasPrefix("http://", ep) { + if strings.HasPrefix(ep, "http://") { fmt.Fprintf(os.Stderr, "ignoring discovered insecure endpoint %q\n", ep) continue }