Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape '$' in replacement string for async file copying #291

Merged

Conversation

hhamilto
Copy link
Contributor

@hhamilto hhamilto commented Oct 26, 2016

Change made in /lib/copy/ncp.js to the string.replace in the onFile function

Fixes #242.

Change made in /lib/copy/ncp.js to the string.replace in the onFile function
Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, never knew JS had this functionality.

@hhamilto In the future, if you can ref the corresponding issue in the PR description, that helps me keep organized. Thanks!

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 26, 2016

Fixes #242.

@jprichardson ?

@hhamilto
Copy link
Contributor Author

@RyanZim oops, sorry for that. I'll make sure to next time.

@jprichardson jprichardson merged commit 89aeac2 into jprichardson:master Oct 26, 2016
@jprichardson
Copy link
Owner

Thank you @hhamilto!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants