BREAKING: Remove support for setting spaces for JSON writing #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jprichardson
reviewed
Apr 9, 2017
lib/json/jsonfile.js
Outdated
| @@ -2,15 +2,21 @@ | |||
|
|
|||
| const jsonFile = require('jsonfile') | |||
|
|
|||
| function write () { | |||
| jsonFile.writeFile.apply({ spaces: 2 }, arguments) | |||
There was a problem hiding this comment.
Seems to me it should follow the jsonfile default of null spaces. Don't you think?
There was a problem hiding this comment.
It would definitely be simpler to do it that way; if no one's opposed, I'll change this.
|
@jprichardson Fixed. |
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #401
Note that this PR is against the new
developbranch, which will be used for v3.0.0