Housekeeping #277
Open
Housekeeping #277
+30
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 9 9
Lines 1025 1025
Branches 216 177 -39
=======================================
Hits 977 977
Misses 44 44
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jquast
reviewed
Dec 10, 2024
| @@ -155,7 +154,7 @@ def wrapper(decorator): | |||
| # html_theme_options = {} | |||
|
|
|||
| # Add any paths that contain custom themes here, relative to this directory. | |||
| html_theme_path = [sphinx_rtd_theme.get_html_theme_path()] | |||
| # html_theme_path = [] | |||
There was a problem hiding this comment.
You don't mention why to remove this, I think I put it here to match local development to the theme where it is published, in any case it uses a requirement "sphinx_rtd_theme" in docs/requirements.txt, so then that requirement should also be removed.
Sorry to be late, I've been busy with school work but that's all over tomorrow
jquast
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few housekeeping tasks
Termcap.build()csv-tableused for keycodes now requires the deliminator in the header rather than a comma