Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to hooks? #1620

Closed
sibelius opened this issue Mar 25, 2020 · 14 comments
Closed

refactor to hooks? #1620

sibelius opened this issue Mar 25, 2020 · 14 comments

Comments

@sibelius
Copy link

Do you want to request a feature or report a bug?

feature

What's the current behavior?

it shows many warnings in strict mode

related to #1570
and #1481

What's the expected behavior?

it should work well without warnings in strict mode

would you accept a migration to hooks to fix all this warnings?

@jquense
Copy link
Owner

jquense commented Mar 25, 2020

sure, always open to PRs. They need to be thorough tho, i don't have much time to review for this lib!

@GingerJams206
Copy link

I'm using this in a project of my own...has this gone anywhere since March of 2020?

@jquense
Copy link
Owner

jquense commented Jul 30, 2021

nope!

@DanielUche
Copy link

Is this still an issue, I want to use this component in a new project but I fear this warning is an issue.

@mdestafadilah
Copy link

Any alternative here?

@jbcortez
Copy link

Well this is a huge bummer. Any plans on ever fixing this? Also, any alternative packages out there? I'd hate to have to build a calendar from scratch.

@mdestafadilah
Copy link

I think someone created a hook version and done. nice job @AugustoCalaca #1687 , please close this issued @sibelius. thx

@andresmurillo13
Copy link

react_devtools_backend.js:4012 Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://reactjs.org/link/unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://reactjs.org/link/derived-state

Please update the following components: DayColumn2

@royscript
Copy link

I had these error. Please, upgrade the code.

image

@bu6n
Copy link
Contributor

bu6n commented Feb 6, 2023

Don't want to sound harsh but this is an open source project and most people fixing bugs are doing so for free. We have a Slack space where we are discussing the next version of react-big-calendar. It's not as easy as "upgrading the code". If you want to help: https://join.slack.com/t/bigcalendar/shared_invite/zt-1ml1j99af-qIvqOfosMog1W7WxM0~j2Q

@MichaelKleyman
Copy link

The slack channel is down. Would anyone in this issue thread be open to tackling this issue ourselves. Its open source so maybe we can fix the issue.

@cutterbl
Copy link
Collaborator

Slack channel isn't down...

@MichaelKleyman
Copy link

Update, i ended up fixing the issue on my end, nothing wrong with the RBC code as far as i know. For future nextjs13 and higher version users, simply going into the next.config.js and setting the config as shown below fixes the issue because by default strictmode is set to true, and that was causing my issue

const nextConfig = {
reactStrictMode: false,
};

@travelerr
Copy link

travelerr commented Nov 29, 2023

Update, i ended up fixing the issue on my end, nothing wrong with the RBC code as far as i know. For future nextjs13 and higher version users, simply going into the next.config.js and setting the config as shown below fixes the issue because by default strictmode is set to true, and that was causing my issue

const nextConfig = { reactStrictMode: false, };

can confirm this worked for me. thank you

using nextjs 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests