Merge pull request ManageIQ#18825 from Fryguy/dont_do_rubys_job

Remove Job.get_job_class method
jrafanie · May 30, 2019 · 8ecc9fe · 8ecc9fe
2 parents c95298f + da1b315
commit 8ecc9fe
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/app/models/job.rb b/app/models/job.rb
@@ -16,14 +16,8 @@ class Job < ApplicationRecord
  DEFAULT_TIMEOUT = 300
  DEFAULT_USERID = 'system'.freeze
 
- def self.get_job_class(process_type)
- return Object.const_get(process_type)
- rescue NameError
- raise "Cannot Find Job Class=<#{process_type}> because it is not defined"
- end
-
  def self.create_job(process_type, options = {})
- klass = get_job_class(process_type)
+ klass = Object.const_get(process_type)
  ar_options = options.dup.delete_if { |k, _v| !Job.column_names.include?(k.to_s) }
  job = klass.new(ar_options)
  job.options = options