Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower end of version range should not be included in output #3

Closed
stopfstedt opened this issue Jan 22, 2019 · 2 comments
Closed

lower end of version range should not be included in output #3

stopfstedt opened this issue Jan 22, 2019 · 2 comments

Comments

@stopfstedt
Copy link
Contributor

case in point:

*   8b66100 - (HEAD -> master, tag: v1.3.1, upstream/master) Merge pull request #266 from stopfstedt/fix_rl_indicators (10 hours ago) <Stefan Topfstedt>
|\  
| * b98b41c - (origin/fix_rl_indicators, fix_rl_indicators) fixed switcheroo. (10 hours ago) <Stefan Topfstedt>
|/  
*   87ff923 - (tag: v1.3.0, origin/master, origin/HEAD) Merge pull request #264 from stopfstedt/restricted_lists (20 hours ago) <Stefan Topfstedt>

running generate-github-release-notes thronesdb thronesdb v1.3.0 v1.3.1 yields:

# v1.3.1

## [v1.3.1](https://github.com/thronesdb/thronesdb/tree/v1.3.1)

[Full Changelog](https://github.com/thronesdb/thronesdb/compare/v1.3.0...v1.3.1)


**Fixed Bugs:**

- restricted list indicators in &quot;my decks&quot; are reversed [\#265](https://github.com/ThronesDB/thronesdb/issues/265)


**Closed issues:**

- Restricted Lists validation and indicators [\#247](https://github.com/ThronesDB/thronesdb/issues/247)

**Merged pull requests:**

- fixed switcheroo. [\#266](https://github.com/ThronesDB/thronesdb/pull/266) [@stopfstedt](https://github.com/stopfstedt)
- Restricted list indicators [\#264](https://github.com/ThronesDB/thronesdb/pull/264) [@stopfstedt](https://github.com/stopfstedt)


\* *These notes were automatically created by [generate-github-release-notes](https://github.com/jrjohnson/generate-github-release-notes)*

the line items pertaining to issues 247 and 264 should not be part of the output.

@jrjohnson
Copy link
Owner

This seems to be a weakness in the github API. I think these show up because we can only find things merged since a date https://help.github.com/articles/searching-issues-and-pull-requests/#search-by-when-an-issue-or-pull-request-was-closed but the parameter is only granular to the day and these two tags are on the same day.

@jrjohnson
Copy link
Owner

I made a change in #12, but it doesn't seem to help. Unless I'm reading this wrong though your tag happened before the problem issues were merged. Since github issues aren't tied to a commit I can't just use the commit history, I have to go back and look at the date.

Closed on:
closed on

tagged at:
tagged at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants