Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of .live() method and compatibility with JQuery 1.9 onwards #4

Open
simonlamb opened this issue Aug 21, 2013 · 0 comments
Open

Comments

@simonlamb
Copy link

I've utilised this very useful gem for our Blacklight instance. I've noticed since upgrading our local Jquery library that the 'live' function call at https://github.com/jronallo/blacklight_google_analytics/blob/master/app/assets/javascripts/blacklight_google_analytics.js.erb#L66 is throwing a TypeError.

I fixed locally by changing the line from:-

$('#facets h3').live('click', function(){

to:-

$('#facets').on('click', 'h3', function(){

Thanks,
Simon

mhk33 added a commit to cul-it/blacklight-cornell that referenced this issue Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant