Skip to content

Don't use PHP's fmod #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2018
Merged

Don't use PHP's fmod #470

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd87f30
Don't use PHP's fmod
Nov 28, 2017
1b51bd2
Simplify the private fmod function
Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/JsonSchema/Constraints/NumberConstraint.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public function check(&$element, $schema = null, JsonPointer $path = null, $i =
private function fmod($number1, $number2)
{
$number1 = abs($number1);
$modulus = fmod($number1, $number2);
$modulus = ($number1 - round($number1 / $number2) * $number2);
$precision = abs(0.0000000001);
$diff = (float) ($modulus - $number2);

Expand Down