Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add excluded-module publish error #318

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 21, 2024

No description provided.

@@ -447,3 +447,17 @@ case, you can un-ignore the `dist/` directory by using a negation in the

In this case, the `dist/` directory will be included when publishing, even
though it is listed in the `.gitignore` file.

### Excluded module publish error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to troubleshooting.md instead of publishing-packages.md?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered about that, but all those errors seemed to be server side? I can move it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to put all the troubleshooting instructions in one place.

@lucacasonato lucacasonato enabled auto-merge March 22, 2024 18:39
@lucacasonato lucacasonato added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit f387fc6 Mar 22, 2024
8 checks passed
@lucacasonato lucacasonato deleted the docs_excluded_module_publish_error branch March 22, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants