Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: directly specify location of package.json missing i18n config #401

Merged
merged 1 commit into from
Mar 4, 2021
Merged

fix: directly specify location of package.json missing i18n config #401

merged 1 commit into from
Mar 4, 2021

Conversation

ChazUK
Copy link
Contributor

@ChazUK ChazUK commented Feb 10, 2021

I found it a bit hard trying to track down bad package.json files when using this across a large project with many scopes. This change clarifies which package.json has failed the check for i18n config.

PR Checklist

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe:

What is the current behavior?

Console output when bad package.json is used only says package.json missing ...

What is the new behavior?

Output contains package.json location by using the lib.src parameter.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@itayod itayod merged commit 54ee98a into jsverse:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants