-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed small issue with ordering of statements in extract_text
#385
Conversation
`chars = to_list(chars)` and `len(chars)` need to be swapped to avoid error sometimes.
Codecov Report
@@ Coverage Diff @@
## stable #385 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 10 10
Lines 1205 1205
=======================================
Hits 1184 1184
Misses 21 21
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate you opening a PR @alexreg Request you to add a test case that passes on this commit and fails otherwise.
@samkit-jain Sure, will do. How do I run tests though? Ideally, this should be documented in the README. |
Thanks, @alexreg and @samkit-jain. I really appreciate the test addition — generally ... but also specifically in this case, because it clarifies what's going on here: The previous code didn't work when the |
And, yes, @alexreg — it's definitely worth us adding PR guidelines (including re. tests). Will open an issue on that and self-assign. |
@jsvine That was my thought too, basically. Thanks for merging. |
chars = to_list(chars)
andlen(chars)
need to be swapped to avoid error sometimes.Fixes issue #386.