You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit/PR fixes the slowdown in .extract_words(...) and WordExtractor.iter_chars_to_words(...) which occurred for very long "words", and which was caused by repeatedly re-calculating bounding box. See #483 for discussion and example.
It also adds utils.merge_bboxes(bboxes), which returns the smallest bounding box that contains all bounding boxes in the bboxes argument, and which we use in the fix.
This commit fixes the slowdown in `.extract_words(...)` and
`WordExtractor.iter_chars_to_words(...)` which occurred for very long
"words", and which was caused by repeatedly re-calculating bounding box.
See #483 for discussion and example.
It also adds `utils.merge_bboxes(bboxes)`, which returns the smallest
bounding box that contains all bounding boxes in the `bboxes` argument,
and which we use in the fix.
Merging #497 (2f598b4) into develop (9019854) will increase coverage by 0.01%.
The diff coverage is 100.00%.
❗ Current head 2f598b4 differs from pull request most recent head f8d5e70. Consider uploading reports for the commit f8d5e70 to get more accurate results
@jsvine Do we also have any time comparison stats to validate that it is now indeed faster? As per https://stackoverflow.com/a/19527487/7760998, we can also look at adding a test for it based on the PDF that was shared in the issue/discussion.
@samkit-jain Apologies for missing your comment here. I conducted some informal tests noted in #483 (reply in thread) but nothing very rigorous. Certainly open to adding a test!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit/PR fixes the slowdown in
.extract_words(...)andWordExtractor.iter_chars_to_words(...)which occurred for very long "words", and which was caused by repeatedly re-calculating bounding box. See #483 for discussion and example.It also adds
utils.merge_bboxes(bboxes), which returns the smallest bounding box that contains all bounding boxes in thebboxesargument, and which we use in the fix.