Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint v4 #266

Closed
alexander-akait opened this issue Jun 13, 2017 · 4 comments
Closed

Support eslint v4 #266

alexander-akait opened this issue Jun 13, 2017 · 4 comments

Comments

@alexander-akait
Copy link

No description provided.

@beefancohen
Copy link
Contributor

Doesn't seem like anything needs to be done on our end, except upgrade peerDependencies. notice anything in the migration guide/changelog that would affect this plugin?

@ljharb
Copy link
Member

ljharb commented Jun 14, 2017

@evcohen we should make sure that our peer dep is ^3 || ^4 tho, so it can be compatible with both.

Generally the changes are "invalid configs throw now", and some rules got stricter - so I don't think it would impact us.

@alexander-akait
Copy link
Author

@ljharb we can use >=3 as in prettier/eslint-plugin-prettier#30

@ljharb
Copy link
Member

ljharb commented Jun 14, 2017

That's dangerous, because then a v5 breaking change might break us. Just like you should never do *, you shouldn't ever do >.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants