[minor] jsx-no-target-blank: warn on target={'_blank'} expressions

jsx-eslint · Oct 7, 2019 · 03bdefc · 03bdefc
1 parent 1436799
commit 03bdefc
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/lib/rules/jsx-no-target-blank.js b/lib/rules/jsx-no-target-blank.js
@@ -16,8 +16,15 @@ function isTargetBlank(attr) {
   return attr.name &&
     attr.name.name === 'target' &&
     attr.value &&
-    attr.value.type === 'Literal' &&
-    attr.value.value.toLowerCase() === '_blank';
+    ((
+      attr.value.type === 'Literal' &&
+      attr.value.value.toLowerCase() === '_blank'
+    ) || (
+      attr.value.type === 'JSXExpressionContainer' &&
+      attr.value.expression &&
+      attr.value.expression.value &&
+      attr.value.expression.value.toLowerCase() === '_blank'
+    ));
 }
 
 function hasExternalLink(element, linkAttribute) {

diff --git a/tests/lib/rules/jsx-no-target-blank.js b/tests/lib/rules/jsx-no-target-blank.js
@@ -45,10 +45,20 @@ ruleTester.run('jsx-no-target-blank', rule, {
     {code: '<a target={targetValue} rel="noopener noreferrer"></a>'},
     {code: '<a target={targetValue} href="relative/path"></a>'},
     {code: '<a target={targetValue} href="/absolute/path"></a>'},
+    {code: '<a target={\'targetValue\'} href="/absolute/path"></a>'},
+    {code: '<a target={"targetValue"} href="/absolute/path"></a>'},
     {
       code: '<a target="_blank" href={ dynamicLink }></a>',
       options: [{enforceDynamicLinks: 'never'}]
     },
+    {
+      code: '<a target={"_blank"} href={ dynamicLink }></a>',
+      options: [{enforceDynamicLinks: 'never'}]
+    },
+    {
+      code: '<a target={\'_blank\'} href={ dynamicLink }></a>',
+      options: [{enforceDynamicLinks: 'never'}]
+    },
     {
       code: '<Link target="_blank" href={ dynamicLink }></Link>',
       options: [{enforceDynamicLinks: 'never'}],
@@ -90,6 +100,12 @@ ruleTester.run('jsx-no-target-blank', rule, {
   }, {
     code: '<a target="_blank" href={ dynamicLink }></a>',
     errors: defaultErrors
+  }, {
+    code: '<a target={\'_blank\'} href="//example.com"></a>',
+    errors: defaultErrors
+  }, {
+    code: '<a target={"_blank"} href="//example.com"></a>',
+    errors: defaultErrors
   }, {
     code: '<a target="_blank" href={ dynamicLink }></a>',
     options: [{enforceDynamicLinks: 'always'}],