From 3b6bacc18344204bd587f721fcf4ba71e41d530b Mon Sep 17 00:00:00 2001
From: Jordan Harband <ljharb@gmail.com>
Date: Mon, 29 Jul 2024 22:26:08 -0700
Subject: [PATCH] [Refactor] general cleanup

---
 lib/rules/boolean-prop-naming.js           |  20 ++--
 lib/rules/display-name.js                  |   8 +-
 lib/rules/forbid-prop-types.js             |  36 +++---
 lib/rules/jsx-no-bind.js                   |   8 +-
 lib/rules/no-array-index-key.js            |  32 +++---
 lib/rules/no-find-dom-node.js              |   7 +-
 lib/rules/no-set-state.js                  |   3 +-
 lib/rules/no-string-refs.js                |  21 ++--
 lib/rules/no-typos.js                      |   3 +-
 lib/rules/no-unknown-property.js           |  10 +-
 lib/rules/no-unsafe.js                     |   9 +-
 lib/rules/no-unstable-nested-components.js |   2 +-
 lib/rules/no-unused-state.js               |  22 ++--
 lib/rules/prefer-stateless-function.js     |   4 +-
 lib/rules/require-optimization.js          |   5 +-
 lib/rules/sort-prop-types.js               |  32 +++---
 lib/util/Components.js                     |  45 +++++---
 lib/util/ast.js                            | 128 +++++++++++----------
 lib/util/componentUtil.js                  |   4 +-
 lib/util/isCreateContext.js                |  51 ++++----
 lib/util/isCreateElement.js                |  11 +-
 lib/util/isDestructuredFromPragmaImport.js |  22 ++--
 lib/util/isFirstLetterCapitalized.js       |   6 +-
 lib/util/jsx.js                            |   2 +-
 lib/util/propTypes.js                      |  23 +++-
 lib/util/propTypesSort.js                  |   8 +-
 lib/util/props.js                          |   3 +-
 lib/util/usedPropTypes.js                  |  30 +++--
 28 files changed, 300 insertions(+), 255 deletions(-)

diff --git a/lib/rules/boolean-prop-naming.js b/lib/rules/boolean-prop-naming.js
index e856a17967..2c48b5a7bd 100644
--- a/lib/rules/boolean-prop-naming.js
+++ b/lib/rules/boolean-prop-naming.js
@@ -180,15 +180,17 @@ module.exports = {
      * @param {Function} addInvalidProp callback to run for each error
      */
     function runCheck(proptypes, addInvalidProp) {
-      (proptypes || []).forEach((prop) => {
-        if (config.validateNested && nestedPropTypes(prop)) {
-          runCheck(prop.value.arguments[0].properties, addInvalidProp);
-          return;
-        }
-        if (flowCheck(prop) || regularCheck(prop) || tsCheck(prop)) {
-          addInvalidProp(prop);
-        }
-      });
+      if (proptypes) {
+        proptypes.forEach((prop) => {
+          if (config.validateNested && nestedPropTypes(prop)) {
+            runCheck(prop.value.arguments[0].properties, addInvalidProp);
+            return;
+          }
+          if (flowCheck(prop) || regularCheck(prop) || tsCheck(prop)) {
+            addInvalidProp(prop);
+          }
+        });
+      }
     }
 
     /**
diff --git a/lib/rules/display-name.js b/lib/rules/display-name.js
index 5e5b8b6980..027882a461 100644
--- a/lib/rules/display-name.js
+++ b/lib/rules/display-name.js
@@ -76,9 +76,11 @@ module.exports = {
      * @returns {boolean} True if React.forwardRef is nested inside React.memo, false if not.
      */
     function isNestedMemo(node) {
-      const argumentIsCallExpression = node.arguments && node.arguments[0] && node.arguments[0].type === 'CallExpression';
-
-      return node.type === 'CallExpression' && argumentIsCallExpression && utils.isPragmaComponentWrapper(node);
+      return node.type === 'CallExpression'
+        && node.arguments
+        && node.arguments[0]
+        && node.arguments[0].type === 'CallExpression'
+        && utils.isPragmaComponentWrapper(node);
     }
 
     /**
diff --git a/lib/rules/forbid-prop-types.js b/lib/rules/forbid-prop-types.js
index b561b26da1..581c8969b9 100644
--- a/lib/rules/forbid-prop-types.js
+++ b/lib/rules/forbid-prop-types.js
@@ -158,29 +158,25 @@ module.exports = {
     }
 
     function checkNode(node) {
-      switch (node && node.type) {
-        case 'ObjectExpression':
-          checkProperties(node.properties);
-          break;
-        case 'Identifier': {
-          const propTypesObject = variableUtil.findVariableByName(context, node, node.name);
-          if (propTypesObject && propTypesObject.properties) {
-            checkProperties(propTypesObject.properties);
-          }
-          break;
+      if (!node) {
+        return;
+      }
+
+      if (node.type === 'ObjectExpression') {
+        checkProperties(node.properties);
+      } else if (node.type === 'Identifier') {
+        const propTypesObject = variableUtil.findVariableByName(context, node, node.name);
+        if (propTypesObject && propTypesObject.properties) {
+          checkProperties(propTypesObject.properties);
         }
-        case 'CallExpression': {
-          const innerNode = node.arguments && node.arguments[0];
-          if (
-            propWrapperUtil.isPropWrapperFunction(context, getText(context, node.callee))
+      } else if (node.type === 'CallExpression') {
+        const innerNode = node.arguments && node.arguments[0];
+        if (
+          propWrapperUtil.isPropWrapperFunction(context, getText(context, node.callee))
             && innerNode
-          ) {
-            checkNode(innerNode);
-          }
-          break;
+        ) {
+          checkNode(innerNode);
         }
-        default:
-          break;
       }
     }
 
diff --git a/lib/rules/jsx-no-bind.js b/lib/rules/jsx-no-bind.js
index 4d6e349d25..588ff0b03f 100644
--- a/lib/rules/jsx-no-bind.js
+++ b/lib/rules/jsx-no-bind.js
@@ -93,21 +93,21 @@ module.exports = {
       ) {
         return 'bindCall';
       }
-      if (nodeType === 'ConditionalExpression') {
+      if (node.type === 'ConditionalExpression') {
         return getNodeViolationType(node.test)
                || getNodeViolationType(node.consequent)
                || getNodeViolationType(node.alternate);
       }
-      if (!configuration.allowArrowFunctions && nodeType === 'ArrowFunctionExpression') {
+      if (!configuration.allowArrowFunctions && node.type === 'ArrowFunctionExpression') {
         return 'arrowFunc';
       }
       if (
         !configuration.allowFunctions
-        && (nodeType === 'FunctionExpression' || nodeType === 'FunctionDeclaration')
+        && (node.type === 'FunctionExpression' || node.type === 'FunctionDeclaration')
       ) {
         return 'func';
       }
-      if (!configuration.allowBind && nodeType === 'BindExpression') {
+      if (!configuration.allowBind && node.type === 'BindExpression') {
         return 'bindExpression';
       }
 
diff --git a/lib/rules/no-array-index-key.js b/lib/rules/no-array-index-key.js
index 2a0ae41e6f..ffd5c927b4 100644
--- a/lib/rules/no-array-index-key.js
+++ b/lib/rules/no-array-index-key.js
@@ -189,14 +189,15 @@ module.exports = {
         return;
       }
 
-      if (node.type === 'CallExpression'
-          && node.callee
-          && node.callee.type === 'MemberExpression'
-          && node.callee.object
-          && isArrayIndex(node.callee.object)
-          && node.callee.property
-          && node.callee.property.type === 'Identifier'
-          && node.callee.property.name === 'toString'
+      if (
+        node.type === 'CallExpression'
+        && node.callee
+        && node.callee.type === 'MemberExpression'
+        && node.callee.object
+        && isArrayIndex(node.callee.object)
+        && node.callee.property
+        && node.callee.property.type === 'Identifier'
+        && node.callee.property.name === 'toString'
       ) {
         // key={bar.toString()}
         report(context, messages.noArrayIndex, 'noArrayIndex', {
@@ -205,13 +206,14 @@ module.exports = {
         return;
       }
 
-      if (node.type === 'CallExpression'
-          && node.callee
-          && node.callee.type === 'Identifier'
-          && node.callee.name === 'String'
-          && Array.isArray(node.arguments)
-          && node.arguments.length > 0
-          && isArrayIndex(node.arguments[0])
+      if (
+        node.type === 'CallExpression'
+        && node.callee
+        && node.callee.type === 'Identifier'
+        && node.callee.name === 'String'
+        && Array.isArray(node.arguments)
+        && node.arguments.length > 0
+        && isArrayIndex(node.arguments[0])
       ) {
         // key={String(bar)}
         report(context, messages.noArrayIndex, 'noArrayIndex', {
diff --git a/lib/rules/no-find-dom-node.js b/lib/rules/no-find-dom-node.js
index 0dae59da43..3d9ef52ef8 100644
--- a/lib/rules/no-find-dom-node.js
+++ b/lib/rules/no-find-dom-node.js
@@ -35,8 +35,11 @@ module.exports = {
       CallExpression(node) {
         const callee = node.callee;
 
-        const isfindDOMNode = (callee.name === 'findDOMNode')
-          || (callee.property && callee.property.name === 'findDOMNode');
+        const isfindDOMNode = callee.name === 'findDOMNode' || (
+          callee.property
+          && callee.property.name === 'findDOMNode'
+        );
+
         if (!isfindDOMNode) {
           return;
         }
diff --git a/lib/rules/no-set-state.js b/lib/rules/no-set-state.js
index 0866552141..44967bf03c 100644
--- a/lib/rules/no-set-state.js
+++ b/lib/rules/no-set-state.js
@@ -49,9 +49,8 @@ module.exports = {
      * @param {Object} component The component to process
      */
     function reportSetStateUsages(component) {
-      let setStateUsage;
       for (let i = 0, j = component.setStateUsages.length; i < j; i++) {
-        setStateUsage = component.setStateUsages[i];
+        const setStateUsage = component.setStateUsages[i];
         report(context, messages.noSetState, 'noSetState', {
           node: setStateUsage,
         });
diff --git a/lib/rules/no-string-refs.js b/lib/rules/no-string-refs.js
index c5c3b29166..bef6440441 100644
--- a/lib/rules/no-string-refs.js
+++ b/lib/rules/no-string-refs.js
@@ -62,11 +62,9 @@ module.exports = {
      * @returns {boolean} True if we are using a ref attribute, false if not.
      */
     function isRefAttribute(node) {
-      return !!(
-        node.type === 'JSXAttribute'
-        && node.name
-        && node.name.name === 'ref'
-      );
+      return node.type === 'JSXAttribute'
+        && !!node.name
+        && node.name.name === 'ref';
     }
 
     /**
@@ -75,11 +73,9 @@ module.exports = {
      * @returns {boolean} True if the node contains a string value, false if not.
      */
     function containsStringLiteral(node) {
-      return !!(
-        node.value
+      return !!node.value
         && node.value.type === 'Literal'
-        && typeof node.value.value === 'string'
-      );
+        && typeof node.value.value === 'string';
     }
 
     /**
@@ -88,13 +84,11 @@ module.exports = {
      * @returns {boolean} True if the node contains a string value within a jsx expression, false if not.
      */
     function containsStringExpressionContainer(node) {
-      return !!(
-        node.value
+      return !!node.value
         && node.value.type === 'JSXExpressionContainer'
         && node.value.expression
         && ((node.value.expression.type === 'Literal' && typeof node.value.expression.value === 'string')
-        || (node.value.expression.type === 'TemplateLiteral' && detectTemplateLiterals))
-      );
+        || (node.value.expression.type === 'TemplateLiteral' && detectTemplateLiterals));
     }
 
     return {
@@ -105,6 +99,7 @@ module.exports = {
           });
         }
       },
+
       JSXAttribute(node) {
         if (
           isRefAttribute(node)
diff --git a/lib/rules/no-typos.js b/lib/rules/no-typos.js
index 3d79d40b18..d60d2e7cf2 100644
--- a/lib/rules/no-typos.js
+++ b/lib/rules/no-typos.js
@@ -194,7 +194,8 @@ module.exports = {
           }
           if (node.specifiers.length >= 1) {
             const propTypesSpecifier = node.specifiers.find((specifier) => (
-              specifier.imported && specifier.imported.name === 'PropTypes'
+              specifier.imported
+              && specifier.imported.name === 'PropTypes'
             ));
             if (propTypesSpecifier) {
               propTypesPackageName = propTypesSpecifier.local.name;
diff --git a/lib/rules/no-unknown-property.js b/lib/rules/no-unknown-property.js
index 61ca8ad809..50134264d1 100644
--- a/lib/rules/no-unknown-property.js
+++ b/lib/rules/no-unknown-property.js
@@ -463,7 +463,11 @@ function isValidAriaAttribute(name) {
  * @returns {string | null} tag name
  */
 function getTagName(node) {
-  if (node && node.parent && node.parent.name && node.parent.name) {
+  if (
+    node
+    && node.parent
+    && node.parent.name
+  ) {
     return node.parent.name.name;
   }
   return null;
@@ -592,7 +596,9 @@ module.exports = {
         // Let's dive deeper into tags that are HTML/DOM elements (`<button>`), and not React components (`<Button />`)
 
         // Some attributes are allowed on some tags only
-        const allowedTags = has(ATTRIBUTE_TAGS_MAP, name) ? ATTRIBUTE_TAGS_MAP[/** @type {keyof ATTRIBUTE_TAGS_MAP} */ (name)] : null;
+        const allowedTags = has(ATTRIBUTE_TAGS_MAP, name)
+          ? ATTRIBUTE_TAGS_MAP[/** @type {keyof ATTRIBUTE_TAGS_MAP} */ (name)]
+          : null;
         if (tagName && allowedTags) {
           // Scenario 1A: Allowed attribute found where not supposed to, report it
           if (allowedTags.indexOf(tagName) === -1) {
diff --git a/lib/rules/no-unsafe.js b/lib/rules/no-unsafe.js
index 66d828338a..ae59b88095 100644
--- a/lib/rules/no-unsafe.js
+++ b/lib/rules/no-unsafe.js
@@ -57,18 +57,15 @@ module.exports = {
     const unsafe = {
       UNSAFE_componentWillMount: {
         newMethod: 'componentDidMount',
-        details:
-          'See https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html.',
+        details: 'See https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html.',
       },
       UNSAFE_componentWillReceiveProps: {
         newMethod: 'getDerivedStateFromProps',
-        details:
-          'See https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html.',
+        details: 'See https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html.',
       },
       UNSAFE_componentWillUpdate: {
         newMethod: 'componentDidUpdate',
-        details:
-          'See https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html.',
+        details: 'See https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html.',
       },
     };
     if (checkAliases) {
diff --git a/lib/rules/no-unstable-nested-components.js b/lib/rules/no-unstable-nested-components.js
index 909d8110e7..1f84975634 100644
--- a/lib/rules/no-unstable-nested-components.js
+++ b/lib/rules/no-unstable-nested-components.js
@@ -36,7 +36,7 @@ function generateErrorMessageWithParentName(parentName) {
  * @returns {boolean}
  */
 function startsWithRender(text) {
-  return (text || '').startsWith('render');
+  return typeof text === 'string' && text.startsWith('render');
 }
 
 /**
diff --git a/lib/rules/no-unused-state.js b/lib/rules/no-unused-state.js
index e3b1d37c4b..df3fc35975 100644
--- a/lib/rules/no-unused-state.js
+++ b/lib/rules/no-unused-state.js
@@ -10,7 +10,7 @@
 'use strict';
 
 const docsUrl = require('../util/docsUrl');
-const ast = require('../util/ast');
+const astUtil = require('../util/ast');
 const componentUtil = require('../util/componentUtil');
 const report = require('../util/report');
 const getScope = require('../util/eslint').getScope;
@@ -44,7 +44,7 @@ function getName(node) {
 }
 
 function isThisExpression(node) {
-  return ast.unwrapTSAsExpression(uncast(node)).type === 'ThisExpression';
+  return astUtil.unwrapTSAsExpression(uncast(node)).type === 'ThisExpression';
 }
 
 function getInitialClassInfo() {
@@ -65,7 +65,7 @@ function getInitialClassInfo() {
 }
 
 function isSetStateCall(node) {
-  const unwrappedCalleeNode = ast.unwrapTSAsExpression(node.callee);
+  const unwrappedCalleeNode = astUtil.unwrapTSAsExpression(node.callee);
 
   return (
     unwrappedCalleeNode.type === 'MemberExpression'
@@ -189,7 +189,7 @@ module.exports = {
     // Used to record used state fields and new aliases for both
     // AssignmentExpressions and VariableDeclarators.
     function handleAssignment(left, right) {
-      const unwrappedRight = ast.unwrapTSAsExpression(right);
+      const unwrappedRight = astUtil.unwrapTSAsExpression(right);
 
       switch (left.type) {
         case 'Identifier':
@@ -292,8 +292,8 @@ module.exports = {
           return;
         }
 
-        const unwrappedNode = ast.unwrapTSAsExpression(node);
-        const unwrappedArgumentNode = ast.unwrapTSAsExpression(unwrappedNode.arguments[0]);
+        const unwrappedNode = astUtil.unwrapTSAsExpression(node);
+        const unwrappedArgumentNode = astUtil.unwrapTSAsExpression(unwrappedNode.arguments[0]);
 
         // If we're looking at a `this.setState({})` invocation, record all the
         // properties as state fields.
@@ -308,7 +308,7 @@ module.exports = {
           && unwrappedNode.arguments.length > 0
           && unwrappedArgumentNode.type === 'ArrowFunctionExpression'
         ) {
-          const unwrappedBodyNode = ast.unwrapTSAsExpression(unwrappedArgumentNode.body);
+          const unwrappedBodyNode = astUtil.unwrapTSAsExpression(unwrappedArgumentNode.body);
 
           if (unwrappedBodyNode.type === 'ObjectExpression') {
             addStateFields(unwrappedBodyNode);
@@ -330,7 +330,7 @@ module.exports = {
         }
         // If we see state being assigned as a class property using an object
         // expression, record all the fields of that object as state fields.
-        const unwrappedValueNode = ast.unwrapTSAsExpression(node.value);
+        const unwrappedValueNode = astUtil.unwrapTSAsExpression(node.value);
 
         const name = getName(node.key);
         if (
@@ -452,8 +452,8 @@ module.exports = {
           return;
         }
 
-        const unwrappedLeft = ast.unwrapTSAsExpression(node.left);
-        const unwrappedRight = ast.unwrapTSAsExpression(node.right);
+        const unwrappedLeft = astUtil.unwrapTSAsExpression(node.left);
+        const unwrappedRight = astUtil.unwrapTSAsExpression(node.right);
 
         // Check for assignments like `this.state = {}`
         if (
@@ -493,7 +493,7 @@ module.exports = {
         if (!classInfo) {
           return;
         }
-        if (isStateReference(ast.unwrapTSAsExpression(node.object))) {
+        if (isStateReference(astUtil.unwrapTSAsExpression(node.object))) {
           // If we see this.state[foo] access, give up.
           if (node.computed && node.property.type !== 'Literal') {
             classInfo = null;
diff --git a/lib/rules/prefer-stateless-function.js b/lib/rules/prefer-stateless-function.js
index 8ba33a1a97..0234aacf71 100644
--- a/lib/rules/prefer-stateless-function.js
+++ b/lib/rules/prefer-stateless-function.js
@@ -354,7 +354,9 @@ module.exports = {
           }
           scope = scope.upper;
         }
-        const isRender = blockNode && blockNode.key && blockNode.key.name === 'render';
+        const isRender = blockNode
+          && blockNode.key
+          && blockNode.key.name === 'render';
         const allowNull = testReactVersion(context, '>= 15.0.0'); // Stateless components can return null since React 15
         const isReturningJSX = utils.isReturningJSX(node, !allowNull);
         const isReturningNull = node.argument && (node.argument.value === null || node.argument.value === false);
diff --git a/lib/rules/require-optimization.js b/lib/rules/require-optimization.js
index da6a7e0830..add2ccf95a 100644
--- a/lib/rules/require-optimization.js
+++ b/lib/rules/require-optimization.js
@@ -85,9 +85,10 @@ module.exports = {
       if (allowLength && node.decorators && node.decorators.length) {
         for (let i = 0; i < allowLength; i++) {
           for (let j = 0, l = node.decorators.length; j < l; j++) {
+            const expression = node.decorators[j].expression;
             if (
-              node.decorators[j].expression
-              && node.decorators[j].expression.name === allowDecorators[i]
+              expression
+              && expression.name === allowDecorators[i]
             ) {
               return true;
             }
diff --git a/lib/rules/sort-prop-types.js b/lib/rules/sort-prop-types.js
index b7f3ec4ff5..3dcb7f4690 100644
--- a/lib/rules/sort-prop-types.js
+++ b/lib/rules/sort-prop-types.js
@@ -185,26 +185,22 @@ module.exports = {
     }
 
     function checkNode(node) {
-      switch (node && node.type) {
-        case 'ObjectExpression':
-          checkSorted(node.properties);
-          break;
-        case 'Identifier': {
-          const propTypesObject = variableUtil.findVariableByName(context, node, node.name);
-          if (propTypesObject && propTypesObject.properties) {
-            checkSorted(propTypesObject.properties);
-          }
-          break;
+      if (!node) {
+        return;
+      }
+
+      if (node.type === 'ObjectExpression') {
+        checkSorted(node.properties);
+      } else if (node.type === 'Identifier') {
+        const propTypesObject = variableUtil.findVariableByName(context, node, node.name);
+        if (propTypesObject && propTypesObject.properties) {
+          checkSorted(propTypesObject.properties);
         }
-        case 'CallExpression': {
-          const innerNode = node.arguments && node.arguments[0];
-          if (propWrapperUtil.isPropWrapperFunction(context, node.callee.name) && innerNode) {
-            checkNode(innerNode);
-          }
-          break;
+      } else if (node.type === 'CallExpression') {
+        const innerNode = node.arguments && node.arguments[0];
+        if (propWrapperUtil.isPropWrapperFunction(context, node.callee.name) && innerNode) {
+          checkNode(innerNode);
         }
-        default:
-          break;
       }
     }
 
diff --git a/lib/util/Components.js b/lib/util/Components.js
index 6d9d9e5a9b..9796783bcd 100644
--- a/lib/util/Components.js
+++ b/lib/util/Components.js
@@ -303,20 +303,20 @@ function componentRule(rule, context) {
     },
 
     /**
-     * @param {ASTNode} ASTNode
+     * @param {ASTNode} node
      * @param {boolean=} strict
      * @returns {boolean}
      */
-    isReturningJSX(ASTNode, strict) {
-      return jsxUtil.isReturningJSX(context, ASTNode, strict, true);
+    isReturningJSX(node, strict) {
+      return jsxUtil.isReturningJSX(context, node, strict, true);
     },
 
-    isReturningJSXOrNull(ASTNode, strict) {
-      return jsxUtil.isReturningJSX(context, ASTNode, strict);
+    isReturningJSXOrNull(node, strict) {
+      return jsxUtil.isReturningJSX(context, node, strict);
     },
 
-    isReturningOnlyNull(ASTNode) {
-      return jsxUtil.isReturningOnlyNull(ASTNode, context);
+    isReturningOnlyNull(node) {
+      return jsxUtil.isReturningOnlyNull(node, context);
     },
 
     getPragmaComponentWrapper(node) {
@@ -567,7 +567,13 @@ function componentRule(rule, context) {
         }
 
         // for case abc = { [someobject.somekey]: props => { ... return not-jsx } }
-        if (node.parent && node.parent.key && node.parent.key.type === 'MemberExpression' && !utils.isReturningJSX(node) && !utils.isReturningOnlyNull(node)) {
+        if (
+          node.parent
+          && node.parent.key
+          && node.parent.key.type === 'MemberExpression'
+          && !utils.isReturningJSX(node)
+          && !utils.isReturningOnlyNull(node)
+        ) {
           return undefined;
         }
 
@@ -577,7 +583,10 @@ function componentRule(rule, context) {
             || (!node.id && !node.parent.computed) // case: { f: () => ... }
           )
         ) {
-          if (isFirstLetterCapitalized(node.parent.key.name) && utils.isReturningJSX(node)) {
+          if (
+            isFirstLetterCapitalized(node.parent.key.name)
+            && utils.isReturningJSX(node)
+          ) {
             return node;
           }
           return undefined;
@@ -641,7 +650,7 @@ function componentRule(rule, context) {
      * Get the related component from a node
      *
      * @param {ASTNode} node The AST node being checked (must be a MemberExpression).
-     * @returns {ASTNode} component node, null if we cannot find the component
+     * @returns {ASTNode | null} component node, null if we cannot find the component
      */
     getRelatedComponent(node) {
       let i;
@@ -798,8 +807,14 @@ function componentRule(rule, context) {
         );
 
       const hookResolvedDefs = potentialHookReference && potentialHookReference.resolved.defs;
-      const localHookName = (isPotentialReactHookCall && node.callee.property.name)
-        || (isPotentialHookCall && potentialHookReference && node.callee.name);
+      const localHookName = (
+        isPotentialReactHookCall
+        && node.callee.property.name
+      ) || (
+        isPotentialHookCall
+        && potentialHookReference
+        && node.callee.name
+      );
       const isHookShadowed = isPotentialHookCall
         && hookResolvedDefs
         && hookResolvedDefs.some(
@@ -876,11 +891,11 @@ function componentRule(rule, context) {
         return;
       }
 
-      node = utils.getStatelessComponent(node);
-      if (!node) {
+      const cNode = utils.getStatelessComponent(node);
+      if (!cNode) {
         return;
       }
-      components.add(node, 2);
+      components.add(cNode, 2);
     },
 
     ArrowFunctionExpression(node) {
diff --git a/lib/util/ast.js b/lib/util/ast.js
index 9a11b7532f..cde155a6fb 100644
--- a/lib/util/ast.js
+++ b/lib/util/ast.js
@@ -148,7 +148,11 @@ function traverseReturns(ASTNode, context, onReturn) {
  * @returns {Object} Property name node.
  */
 function getPropertyNameNode(node) {
-  if (node.key || ['MethodDefinition', 'Property'].indexOf(node.type) !== -1) {
+  if (
+    node.key
+    || node.type === 'MethodDefinition'
+    || node.type === 'Property'
+  ) {
     return node.key;
   }
   if (node.type === 'MemberExpression') {
@@ -355,117 +359,115 @@ function unwrapTSAsExpression(node) {
 
 function isTSTypeReference(node) {
   if (!node) return false;
-  const nodeType = node.type;
-  return nodeType === 'TSTypeReference';
+
+  return node.type === 'TSTypeReference';
 }
 
 function isTSTypeAnnotation(node) {
-  if (!node) return false;
-  const nodeType = node.type;
-  return nodeType === 'TSTypeAnnotation';
+  if (!node) { return false; }
+
+  return node.type === 'TSTypeAnnotation';
 }
 
 function isTSTypeLiteral(node) {
-  if (!node) return false;
-  const nodeType = node.type;
-  return nodeType === 'TSTypeLiteral';
+  if (!node) { return false; }
+
+  return node.type === 'TSTypeLiteral';
 }
 
 function isTSIntersectionType(node) {
-  if (!node) return false;
-  const nodeType = node.type;
-  return nodeType === 'TSIntersectionType';
+  if (!node) { return false; }
+
+  return node.type === 'TSIntersectionType';
 }
 
 function isTSInterfaceHeritage(node) {
-  if (!node) return false;
-  const nodeType = node.type;
-  return nodeType === 'TSInterfaceHeritage';
+  if (!node) { return false; }
+
+  return node.type === 'TSInterfaceHeritage';
 }
 
 function isTSInterfaceDeclaration(node) {
-  if (!node) return false;
-  let nodeType = node.type;
-  if (node.type === 'ExportNamedDeclaration' && node.declaration) {
-    nodeType = node.declaration.type;
-  }
-  return nodeType === 'TSInterfaceDeclaration';
+  if (!node) { return false; }
+
+  return (node.type === 'ExportNamedDeclaration' && node.declaration
+    ? node.declaration.type
+    : node.type
+  ) === 'TSInterfaceDeclaration';
 }
 
 function isTSTypeDeclaration(node) {
-  if (!node) return false;
-  let nodeType = node.type;
-  let nodeKind = node.kind;
-  if (node.type === 'ExportNamedDeclaration' && node.declaration) {
-    nodeType = node.declaration.type;
-    nodeKind = node.declaration.kind;
-  }
-  return nodeType === 'VariableDeclaration' && nodeKind === 'type';
+  if (!node) { return false; }
+
+  const nodeToCheck = node.type === 'ExportNamedDeclaration' && node.declaration
+    ? node.declaration
+    : node;
+
+  return nodeToCheck.type === 'VariableDeclaration' && nodeToCheck.kind === 'type';
 }
 
 function isTSTypeAliasDeclaration(node) {
-  if (!node) return false;
-  let nodeType = node.type;
+  if (!node) { return false; }
+
   if (node.type === 'ExportNamedDeclaration' && node.declaration) {
-    nodeType = node.declaration.type;
-    return nodeType === 'TSTypeAliasDeclaration' && node.exportKind === 'type';
+    return node.declaration.type === 'TSTypeAliasDeclaration' && node.exportKind === 'type';
   }
-  return nodeType === 'TSTypeAliasDeclaration';
+  return node.type === 'TSTypeAliasDeclaration';
 }
 
 function isTSParenthesizedType(node) {
-  if (!node) return false;
-  const nodeType = node.type;
-  return nodeType === 'TSTypeAliasDeclaration';
+  if (!node) { return false; }
+
+  return node.type === 'TSTypeAliasDeclaration';
 }
 
 function isTSFunctionType(node) {
-  if (!node) return false;
-  const nodeType = node.type;
-  return nodeType === 'TSFunctionType';
+  if (!node) { return false; }
+
+  return node.type === 'TSFunctionType';
 }
 
 function isTSTypeQuery(node) {
-  if (!node) return false;
-  const nodeType = node.type;
-  return nodeType === 'TSTypeQuery';
+  if (!node) { return false; }
+
+  return node.type === 'TSTypeQuery';
 }
 
 function isTSTypeParameterInstantiation(node) {
-  if (!node) return false;
-  const nodeType = node.type;
-  return nodeType === 'TSTypeParameterInstantiation';
+  if (!node) { return false; }
+
+  return node.type === 'TSTypeParameterInstantiation';
 }
 
 module.exports = {
-  traverse,
   findReturnStatement,
+  getComponentProperties,
   getFirstNodeInLine,
+  getKeyValue,
   getPropertyName,
   getPropertyNameNode,
-  getComponentProperties,
-  getKeyValue,
-  isParenthesized,
+  inConstructor,
   isAssignmentLHS,
   isClass,
   isFunction,
-  isFunctionLikeExpression,
   isFunctionLike,
-  inConstructor,
+  isFunctionLikeExpression,
   isNodeFirstInLine,
+  isParenthesized,
   isTSAsExpression,
-  unwrapTSAsExpression,
-  traverseReturns,
-  isTSTypeReference,
-  isTSTypeAnnotation,
-  isTSTypeLiteral,
-  isTSIntersectionType,
-  isTSInterfaceHeritage,
+  isTSFunctionType,
   isTSInterfaceDeclaration,
-  isTSTypeAliasDeclaration,
+  isTSInterfaceHeritage,
+  isTSIntersectionType,
   isTSParenthesizedType,
-  isTSFunctionType,
-  isTSTypeQuery,
-  isTSTypeParameterInstantiation,
+  isTSTypeAliasDeclaration,
+  isTSTypeAnnotation,
   isTSTypeDeclaration,
+  isTSTypeLiteral,
+  isTSTypeParameterInstantiation,
+  isTSTypeQuery,
+  isTSTypeReference,
+  traverse,
+  traverseReturns,
+  unwrapTSAsExpression,
 };
diff --git a/lib/util/componentUtil.js b/lib/util/componentUtil.js
index f98762a49a..8bd2c720de 100644
--- a/lib/util/componentUtil.js
+++ b/lib/util/componentUtil.js
@@ -174,7 +174,9 @@ function isPureComponent(node, context) {
  * @returns {boolean}
  */
 function isStateMemberExpression(node) {
-  return node.type === 'MemberExpression' && node.object.type === 'ThisExpression' && node.property.name === 'state';
+  return node.type === 'MemberExpression'
+    && node.object.type === 'ThisExpression'
+    && node.property.name === 'state';
 }
 
 module.exports = {
diff --git a/lib/util/isCreateContext.js b/lib/util/isCreateContext.js
index 858f463ccb..fde00a9dc1 100644
--- a/lib/util/isCreateContext.js
+++ b/lib/util/isCreateContext.js
@@ -8,21 +8,22 @@
 module.exports = function isCreateContext(node) {
   if (
     node.init
-    && node.init.type === 'CallExpression'
     && node.init.callee
-    && node.init.callee.name === 'createContext'
   ) {
-    return true;
-  }
+    if (
+      node.init.type === 'CallExpression'
+      && node.init.callee.name === 'createContext'
+    ) {
+      return true;
+    }
 
-  if (
-    node.init
-    && node.init.callee
-    && node.init.callee.type === 'MemberExpression'
-    && node.init.callee.property
-    && node.init.callee.property.name === 'createContext'
-  ) {
-    return true;
+    if (
+      node.init.callee.type === 'MemberExpression'
+      && node.init.callee.property
+      && node.init.callee.property.name === 'createContext'
+    ) {
+      return true;
+    }
   }
 
   if (
@@ -31,22 +32,20 @@ module.exports = function isCreateContext(node) {
     && node.expression.operator === '='
     && node.expression.right.type === 'CallExpression'
     && node.expression.right.callee
-    && node.expression.right.callee.name === 'createContext'
   ) {
-    return true;
-  }
+    const right = node.expression.right;
 
-  if (
-    node.expression
-    && node.expression.type === 'AssignmentExpression'
-    && node.expression.operator === '='
-    && node.expression.right.type === 'CallExpression'
-    && node.expression.right.callee
-    && node.expression.right.callee.type === 'MemberExpression'
-    && node.expression.right.callee.property
-    && node.expression.right.callee.property.name === 'createContext'
-  ) {
-    return true;
+    if (right.callee.name === 'createContext') {
+      return true;
+    }
+
+    if (
+      right.callee.type === 'MemberExpression'
+      && right.callee.property
+      && right.callee.property.name === 'createContext'
+    ) {
+      return true;
+    }
   }
 
   return false;
diff --git a/lib/util/isCreateElement.js b/lib/util/isCreateElement.js
index 9e531964fa..be93cec5f7 100644
--- a/lib/util/isCreateElement.js
+++ b/lib/util/isCreateElement.js
@@ -10,9 +10,12 @@ const isDestructuredFromPragmaImport = require('./isDestructuredFromPragmaImport
  * @returns {boolean} - True if node is a createElement call object literal, False if not.
 */
 module.exports = function isCreateElement(context, node) {
+  if (!node.callee) {
+    return false;
+  }
+
   if (
-    node.callee
-    && node.callee.type === 'MemberExpression'
+    node.callee.type === 'MemberExpression'
     && node.callee.property.name === 'createElement'
     && node.callee.object
     && node.callee.object.name === pragmaUtil.getFromContext(context)
@@ -21,9 +24,7 @@ module.exports = function isCreateElement(context, node) {
   }
 
   if (
-    node
-    && node.callee
-    && node.callee.name === 'createElement'
+    node.callee.name === 'createElement'
     && isDestructuredFromPragmaImport(context, node, 'createElement')
   ) {
     return true;
diff --git a/lib/util/isDestructuredFromPragmaImport.js b/lib/util/isDestructuredFromPragmaImport.js
index 6abf86e84c..dc927d0cff 100644
--- a/lib/util/isDestructuredFromPragmaImport.js
+++ b/lib/util/isDestructuredFromPragmaImport.js
@@ -22,15 +22,15 @@ module.exports = function isDestructuredFromPragmaImport(context, node, variable
         // check for: 'variable = pragma.variable'
         if (
           latestDef.node.init.type === 'MemberExpression'
-              && latestDef.node.init.object.type === 'Identifier'
-              && latestDef.node.init.object.name === pragma
+          && latestDef.node.init.object.type === 'Identifier'
+          && latestDef.node.init.object.name === pragma
         ) {
           return true;
         }
         // check for: '{variable} = pragma'
         if (
           latestDef.node.init.type === 'Identifier'
-              && latestDef.node.init.name === pragma
+          && latestDef.node.init.name === pragma
         ) {
           return true;
         }
@@ -45,8 +45,8 @@ module.exports = function isDestructuredFromPragmaImport(context, node, variable
         // get "require('react')" from: "variable = require('react').variable"
         if (
           !requireExpression
-              && latestDef.node.init.type === 'MemberExpression'
-              && latestDef.node.init.object.type === 'CallExpression'
+          && latestDef.node.init.type === 'MemberExpression'
+          && latestDef.node.init.object.type === 'CallExpression'
         ) {
           requireExpression = latestDef.node.init.object;
         }
@@ -54,10 +54,10 @@ module.exports = function isDestructuredFromPragmaImport(context, node, variable
         // check proper require.
         if (
           requireExpression
-              && requireExpression.callee
-              && requireExpression.callee.name === 'require'
-              && requireExpression.arguments[0]
-              && requireExpression.arguments[0].value === pragma.toLocaleLowerCase()
+          && requireExpression.callee
+          && requireExpression.callee.name === 'require'
+          && requireExpression.arguments[0]
+          && requireExpression.arguments[0].value === pragma.toLocaleLowerCase()
         ) {
           return true;
         }
@@ -68,8 +68,8 @@ module.exports = function isDestructuredFromPragmaImport(context, node, variable
       // latest definition is an import declaration: import {<variable>} from 'react'
       if (
         latestDef.parent
-            && latestDef.parent.type === 'ImportDeclaration'
-            && latestDef.parent.source.value === pragma.toLocaleLowerCase()
+        && latestDef.parent.type === 'ImportDeclaration'
+        && latestDef.parent.source.value === pragma.toLocaleLowerCase()
       ) {
         return true;
       }
diff --git a/lib/util/isFirstLetterCapitalized.js b/lib/util/isFirstLetterCapitalized.js
index 9bbce69c66..3d6252168f 100644
--- a/lib/util/isFirstLetterCapitalized.js
+++ b/lib/util/isFirstLetterCapitalized.js
@@ -5,12 +5,10 @@
  * @param {string} word String to check
  * @returns {boolean} True if first letter is capitalized.
  */
-function isFirstLetterCapitalized(word) {
+module.exports = function isFirstLetterCapitalized(word) {
   if (!word) {
     return false;
   }
   const firstLetter = word.replace(/^_+/, '').charAt(0);
   return firstLetter.toUpperCase() === firstLetter;
-}
-
-module.exports = isFirstLetterCapitalized;
+};
diff --git a/lib/util/jsx.js b/lib/util/jsx.js
index 477dd36f5e..db3413745a 100644
--- a/lib/util/jsx.js
+++ b/lib/util/jsx.js
@@ -76,7 +76,7 @@ function isJSXAttributeKey(node) {
 
 /**
  * Check if value has only whitespaces
- * @param {string} value
+ * @param {unknown} value
  * @returns {boolean}
  */
 function isWhiteSpaces(value) {
diff --git a/lib/util/propTypes.js b/lib/util/propTypes.js
index 8322aab1ce..28a460d6b6 100644
--- a/lib/util/propTypes.js
+++ b/lib/util/propTypes.js
@@ -76,7 +76,7 @@ function iterateProperties(context, properties, fn, handleSpreadFn) {
 /**
  * Checks if a node is inside a class body.
  *
- * @param {ASTNode} node  the AST node being checked.
+ * @param {ASTNode} node the AST node being checked.
  * @returns {boolean} True if the node has a ClassBody ancestor, false if not.
  */
 function isInsideClassBody(node) {
@@ -427,7 +427,6 @@ module.exports = function propTypesInstructions(context, components, utils) {
       value
       && value.type === 'MemberExpression'
       && value.property
-      && value.property.name
       && value.property.name === 'isRequired'
     ) {
       value = value.object;
@@ -497,7 +496,7 @@ module.exports = function propTypesInstructions(context, components, utils) {
         case 'oneOfType': {
           if (
             !argument.elements
-            || !argument.elements.length
+            || argument.elements.length === 0
           ) {
             // Invalid proptype or cannot analyse statically
             return {};
@@ -576,8 +575,12 @@ module.exports = function propTypesInstructions(context, components, utils) {
    */
   function filterInterfaceOrAliasByName(node, typeName) {
     return (
-      (node.id && node.id.name === typeName)
-      || (node.declaration && node.declaration.id && node.declaration.id.name === typeName)
+      node.id
+      && node.id.name === typeName
+    ) || (
+      node.declaration
+      && node.declaration.id
+      && node.declaration.id.name === typeName
     );
   }
 
@@ -695,7 +698,15 @@ module.exports = function propTypesInstructions(context, components, utils) {
 
       const declarations = flatMap(
         candidateTypes,
-        (type) => type.declarations || (type.declaration && type.declaration.declarations) || type.declaration);
+        (type) => (
+          type.declarations
+          || (
+            type.declaration
+            && type.declaration.declarations
+          )
+          || type.declaration
+        )
+      );
 
       // we tried to find either an interface or a type with the TypeReference name
       const typeDeclaration = declarations.filter((dec) => dec.id.name === typeName);
diff --git a/lib/util/propTypesSort.js b/lib/util/propTypesSort.js
index a6bb2124b3..4b42904c63 100644
--- a/lib/util/propTypesSort.js
+++ b/lib/util/propTypesSort.js
@@ -19,7 +19,9 @@ const getText = eslintUtil.getText;
  * @returns {string} The name of the node.
  */
 function getValueName(node) {
-  return node.type === 'Property' && node.value.property && node.value.property.name;
+  return node.type === 'Property'
+    && node.value.property
+    && node.value.property.name;
 }
 
 /**
@@ -64,7 +66,9 @@ function isShapeProp(node) {
  * @returns {Array} the properties of the PropTypes.shape node.
  */
 function getShapeProperties(node) {
-  return node.arguments && node.arguments[0] && node.arguments[0].properties;
+  return node.arguments
+    && node.arguments[0]
+    && node.arguments[0].properties;
 }
 
 /**
diff --git a/lib/util/props.js b/lib/util/props.js
index b5c992890b..f8a114ce6a 100644
--- a/lib/util/props.js
+++ b/lib/util/props.js
@@ -89,7 +89,8 @@ function isDisplayNameDeclaration(node) {
  * @returns {boolean} `true` if this PropType is required, `false` if not.
  */
 function isRequiredPropType(propTypeExpression) {
-  return propTypeExpression.type === 'MemberExpression' && propTypeExpression.property.name === 'isRequired';
+  return propTypeExpression.type === 'MemberExpression'
+    && propTypeExpression.property.name === 'isRequired';
 }
 
 module.exports = {
diff --git a/lib/util/usedPropTypes.js b/lib/util/usedPropTypes.js
index 52d0a2bb66..c5dfc733e9 100644
--- a/lib/util/usedPropTypes.js
+++ b/lib/util/usedPropTypes.js
@@ -113,16 +113,23 @@ function inLifeCycleMethod(context, node, checkAsyncSafeLifeCycles) {
  * @return {boolean} True if the node is a lifecycle method
  */
 function isNodeALifeCycleMethod(node, checkAsyncSafeLifeCycles) {
-  const nodeKeyName = (node.key || /** @type {ASTNode} */ ({})).name;
+  if (node.key) {
+    if (node.kind === 'constructor') {
+      return true;
+    }
 
-  if (node.kind === 'constructor') {
-    return true;
-  }
-  if (LIFE_CYCLE_METHODS.indexOf(nodeKeyName) >= 0) {
-    return true;
-  }
-  if (checkAsyncSafeLifeCycles && ASYNC_SAFE_LIFE_CYCLE_METHODS.indexOf(nodeKeyName) >= 0) {
-    return true;
+    const nodeKeyName = node.key.name;
+
+    if (typeof nodeKeyName !== 'string') {
+      return false;
+    }
+
+    if (LIFE_CYCLE_METHODS.indexOf(nodeKeyName) >= 0) {
+      return true;
+    }
+    if (checkAsyncSafeLifeCycles && ASYNC_SAFE_LIFE_CYCLE_METHODS.indexOf(nodeKeyName) >= 0) {
+      return true;
+    }
   }
 
   return false;
@@ -136,7 +143,10 @@ function isNodeALifeCycleMethod(node, checkAsyncSafeLifeCycles) {
  * @return {boolean} True if the node is inside a lifecycle method
  */
 function isInLifeCycleMethod(node, checkAsyncSafeLifeCycles) {
-  if ((node.type === 'MethodDefinition' || node.type === 'Property') && isNodeALifeCycleMethod(node, checkAsyncSafeLifeCycles)) {
+  if (
+    (node.type === 'MethodDefinition' || node.type === 'Property')
+    && isNodeALifeCycleMethod(node, checkAsyncSafeLifeCycles)
+  ) {
     return true;
   }