Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: change multiline-always to proportional-always #3264

Merged
merged 1 commit into from
May 17, 2022
Merged

Fix: change multiline-always to proportional-always #3264

merged 1 commit into from
May 17, 2022

Conversation

Nokel81
Copy link
Contributor

@Nokel81 Nokel81 commented Apr 5, 2022

  • If the node is multiline then require newline
  • If the node is singleline then require space

Signed-off-by: Sebastian Malton sebastian@malton.name

@Nokel81 @ljharb
[Fix] jsx-tag-spacing: change multiline-always to proportional-always
316bc40 
- If the node is multiline then require newline
- If the node is singleline then require space

Note: breaking wrt jsx-eslint#3260, but it’s unreleased.

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #3264 (25d74d5) into master (c297a96) will decrease coverage by 0.03%.
The diff coverage is 90.62%.

@@            Coverage Diff             @@
##           master    #3264      +/-   ##
==========================================
- Coverage   97.69%   97.66%   -0.04%     
==========================================
  Files         121      121              
  Lines        8586     8593       +7     
  Branches     3118     3121       +3     
==========================================
+ Hits         8388     8392       +4     
- Misses        198      201       +3
Impacted Files Coverage Δ
lib/rules/jsx-tag-spacing.js 97.41% <90.32%> (-2.59%) ⬇️
lib/util/getTokenBeforeClosingBracket.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c297a96...25d74d5. Read the comment docs.

@ljharb
Copy link
Member

ljharb commented Apr 5, 2022

Can you elaborate?

This is a breaking change with respect to #3260, but since it's not yet released, we could safely make it.

ljharb
ljharb reviewed Apr 5, 2022
View reviewed changes
lib/rules/jsx-tag-spacing.js Outdated Show resolved Hide resolved
lib/rules/jsx-tag-spacing.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the jsx-tag-spacing-preportional branch from 25d74d5 to 316bc40 Compare May 16, 2022 22:59
@codecov
Copy link

codecov bot commented May 16, 2022 •
edited
Loading

Codecov Report

Merging #3264 (316bc40) into master (9356230) will decrease coverage by 0.03%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master    #3264      +/-   ##
==========================================
- Coverage   97.70%   97.67%   -0.04%     
==========================================
  Files         123      123              
  Lines        8728     8736       +8     
  Branches     3161     3164       +3     
==========================================
+ Hits         8528     8533       +5     
- Misses        200      203       +3
Impacted Files Coverage Δ
lib/rules/jsx-tag-spacing.js 97.43% <80.00%> (-2.57%) ⬇️
lib/util/getTokenBeforeClosingBracket.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9356230...316bc40. Read the comment docs.

@ljharb ljharb merged commit 316bc40 into jsx-eslint:master May 17, 2022
@Nokel81 Nokel81 deleted the jsx-tag-spacing-preportional branch May 17, 2022 02:36
@burtek
Copy link
Contributor

burtek commented May 22, 2022

Docs not changed? #3294

@ljharb
Copy link
Member

ljharb commented May 23, 2022

yes, they were overlooked.

ljharb added a commit that referenced this pull request May 23, 2022
@ljharb
[Docs] jsx-tag-spacing: rename option from #3264
527db86 
Fixes #3294.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nokel81 @codecov-commenter @ljharb @burtek