-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiline JSX expressions when prevent option is true: jsx-newline
#3311
Allow multiline JSX expressions when prevent option is true: jsx-newline
#3311
Conversation
@ljharb Can you please take a quick look to see if I'm on the right track? Thank you!! |
Codecov Report
@@ Coverage Diff @@
## master #3311 +/- ##
==========================================
- Coverage 97.70% 97.56% -0.14%
==========================================
Files 123 123
Lines 8746 8759 +13
Branches 3168 3172 +4
==========================================
+ Hits 8545 8546 +1
- Misses 201 213 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall!
jsx-newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
7a1634a
to
8887a19
Compare
Fixes #3033
This is an initial PR to confirm that this is the change required to allow multi-lines in the
jsx-newlines
rule.