Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSDoc type annotations #3732

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add JSDoc type annotations #3732

merged 1 commit into from
Apr 10, 2024

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Apr 9, 2024 •
edited
Loading

Adds JSDoc annotations to rules where type changes are unnecessary, as discussed in #3731 (comment)

@ljharb
Copy link
Member

ljharb commented Apr 9, 2024

Is this a duplicate of #3731?

ljharb
ljharb requested changes Apr 9, 2024
View reviewed changes
lib/rules/boolean-prop-naming.js Outdated Show resolved Hide resolved
@y-hsgw
Copy link
Contributor Author

y-hsgw commented Apr 9, 2024

Is this a duplicate of #3731?

Yes.
The change in #3731 was not a simple annotation change, so this PR added annotations only to rules that did not require a type change.

@ljharb ljharb force-pushed the add-jsdoc-type-annotations branch from 94e0e85 to d50d886 Compare April 9, 2024 14:28
@ljharb ljharb merged commit d50d886 into jsx-eslint:master Apr 10, 2024
307 checks passed
@y-hsgw y-hsgw deleted the add-jsdoc-type-annotations branch April 10, 2024 05:42
@y-hsgw y-hsgw mentioned this pull request Apr 10, 2024
Merged
@voxpelli voxpelli mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-hsgw @ljharb