From 68757dbba9920d50e9a810252ddd8baea188b5e5 Mon Sep 17 00:00:00 2001 From: jtr109 Date: Thu, 30 Jul 2020 10:53:43 +0800 Subject: [PATCH 1/8] add coverage with taurpalin --- .github/workflows/coverage.yml | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 .github/workflows/coverage.yml diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml new file mode 100644 index 0000000..e6b7cce --- /dev/null +++ b/.github/workflows/coverage.yml @@ -0,0 +1,31 @@ +name: coverage + +on: + push: + branches: [ master ] + pull_request: + branches: [ master ] + +env: + CARGO_TERM_COLOR: always + +jobs: + test: + name: coverage + # runs-on: ubuntu-latest + # container: + # image: + # options: --security-opt seccomp=unconfined + steps: + - name: Checkout repository + uses: actions/checkout@v2 + + - name: Generate code coverage + run: | + cargo +nightly tarpaulin --verbose --all-features --workspace --timeout 120 --out Xml + + - name: Upload to codecov.io + uses: codecov/codecov-action@v1 + with: + # token: ${{secrets.CODECOV_TOKEN}} # not required for public repos + fail_ci_if_error: true From 1d081fe673b0850c3e6a22216c17cc48acdfec8f Mon Sep 17 00:00:00 2001 From: jtr109 Date: Thu, 30 Jul 2020 11:00:28 +0800 Subject: [PATCH 2/8] use taurpalin github action --- .github/workflows/coverage.yml | 53 +++++++++++++++++++--------------- 1 file changed, 30 insertions(+), 23 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index e6b7cce..37ba1ed 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -1,31 +1,38 @@ -name: coverage +name: coverage on: - push: - branches: [ master ] - pull_request: - branches: [ master ] - -env: - CARGO_TERM_COLOR: always + push: + branches: [ master ] + pull_request: + branches: [ master ] jobs: - test: - name: coverage - # runs-on: ubuntu-latest - # container: - # image: - # options: --security-opt seccomp=unconfined + check: + name: Rust project + runs-on: ubuntu-latest steps: - - name: Checkout repository - uses: actions/checkout@v2 + - name: Checkout repository + uses: actions/checkout@v2 + + - name: Install stable toolchain + uses: actions-rs/toolchain@v1 + with: + toolchain: stable + override: true + + - name: Run cargo-tarpaulin + uses: actions-rs/tarpaulin@v0.1 + with: + version: '0.9.0' + args: '-- --test-threads 1' - - name: Generate code coverage - run: | - cargo +nightly tarpaulin --verbose --all-features --workspace --timeout 120 --out Xml + # - name: Upload to codecov.io + # uses: codecov/codecov-action@v1.0.2 + # with: + # token: ${{secrets.CODECOV_TOKEN}} - - name: Upload to codecov.io - uses: codecov/codecov-action@v1 + - name: Archive code coverage results + uses: actions/upload-artifact@v1 with: - # token: ${{secrets.CODECOV_TOKEN}} # not required for public repos - fail_ci_if_error: true + name: code-coverage-report + path: cobertura.xml From 80bc3ab2eaca708ce2285fb269c7304aaec5bc56 Mon Sep 17 00:00:00 2001 From: jtr109 Date: Thu, 30 Jul 2020 11:05:04 +0800 Subject: [PATCH 3/8] try test failed --- .github/workflows/coverage.yml | 4 +++- three_sum/src/lib.rs | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 37ba1ed..64f53e9 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -1,4 +1,6 @@ -name: coverage +# template: https://github.com/marketplace/actions/rust-tarpaulin + +name: Coverage on: push: diff --git a/three_sum/src/lib.rs b/three_sum/src/lib.rs index 42bb4d7..6c527fe 100644 --- a/three_sum/src/lib.rs +++ b/three_sum/src/lib.rs @@ -53,7 +53,7 @@ mod tests { let given = vec![-1, 0, 1, 2, -1, -4]; let expected: Vec> = vec![vec![-1, 0, 1], vec![-1, -1, 2]]; let got = Solution::three_sum(given); - assert_eq!( + assert_ne!( got.iter().cloned().collect::>>(), expected.iter().cloned().collect::>>(), ); From 2e88049961b543bbaad9fa35cec78cb55d0305f0 Mon Sep 17 00:00:00 2001 From: jtr109 Date: Thu, 30 Jul 2020 11:09:03 +0800 Subject: [PATCH 4/8] assemble test and coverage --- .github/workflows/rust.yml | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 42f7449..8f2a3f6 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -13,6 +13,34 @@ jobs: test: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - name: Checkout repository + uses: actions/checkout@v2 - name: Run tests run: cargo test --verbose + + coverage: + # template: https://github.com/marketplace/actions/rust-tarpaulin + name: Rust project + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v2 + - name: Install stable toolchain + uses: actions-rs/toolchain@v1 + with: + toolchain: stable + override: true + - name: Run cargo-tarpaulin + uses: actions-rs/tarpaulin@v0.1 + with: + version: '0.9.0' + args: '-- --test-threads 1' + # - name: Upload to codecov.io + # uses: codecov/codecov-action@v1.0.2 + # with: + # token: ${{secrets.CODECOV_TOKEN}} + - name: Archive code coverage results + uses: actions/upload-artifact@v1 + with: + name: code-coverage-report + path: cobertura.xml From 4661d3ee808a5d0c5a5f1fe5b4bc9e59e420e959 Mon Sep 17 00:00:00 2001 From: jtr109 Date: Thu, 30 Jul 2020 11:11:42 +0800 Subject: [PATCH 5/8] make test succeed --- .github/workflows/coverage.yml | 40 ---------------------------------- three_sum/src/lib.rs | 2 +- 2 files changed, 1 insertion(+), 41 deletions(-) delete mode 100644 .github/workflows/coverage.yml diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml deleted file mode 100644 index 64f53e9..0000000 --- a/.github/workflows/coverage.yml +++ /dev/null @@ -1,40 +0,0 @@ -# template: https://github.com/marketplace/actions/rust-tarpaulin - -name: Coverage - -on: - push: - branches: [ master ] - pull_request: - branches: [ master ] - -jobs: - check: - name: Rust project - runs-on: ubuntu-latest - steps: - - name: Checkout repository - uses: actions/checkout@v2 - - - name: Install stable toolchain - uses: actions-rs/toolchain@v1 - with: - toolchain: stable - override: true - - - name: Run cargo-tarpaulin - uses: actions-rs/tarpaulin@v0.1 - with: - version: '0.9.0' - args: '-- --test-threads 1' - - # - name: Upload to codecov.io - # uses: codecov/codecov-action@v1.0.2 - # with: - # token: ${{secrets.CODECOV_TOKEN}} - - - name: Archive code coverage results - uses: actions/upload-artifact@v1 - with: - name: code-coverage-report - path: cobertura.xml diff --git a/three_sum/src/lib.rs b/three_sum/src/lib.rs index 6c527fe..42bb4d7 100644 --- a/three_sum/src/lib.rs +++ b/three_sum/src/lib.rs @@ -53,7 +53,7 @@ mod tests { let given = vec![-1, 0, 1, 2, -1, -4]; let expected: Vec> = vec![vec![-1, 0, 1], vec![-1, -1, 2]]; let got = Solution::three_sum(given); - assert_ne!( + assert_eq!( got.iter().cloned().collect::>>(), expected.iter().cloned().collect::>>(), ); From ccea00dc899455b4986a575756246c0fd58049a2 Mon Sep 17 00:00:00 2001 From: jtr109 Date: Thu, 30 Jul 2020 11:17:55 +0800 Subject: [PATCH 6/8] upload coverage to codecov.io --- .github/workflows/rust.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 8f2a3f6..95dda22 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -20,7 +20,6 @@ jobs: coverage: # template: https://github.com/marketplace/actions/rust-tarpaulin - name: Rust project runs-on: ubuntu-latest steps: - name: Checkout repository @@ -35,10 +34,10 @@ jobs: with: version: '0.9.0' args: '-- --test-threads 1' - # - name: Upload to codecov.io - # uses: codecov/codecov-action@v1.0.2 - # with: - # token: ${{secrets.CODECOV_TOKEN}} + - name: Upload to codecov.io + uses: codecov/codecov-action@v1.0.2 + with: + token: ${{secrets.CODECOV_TOKEN}} - name: Archive code coverage results uses: actions/upload-artifact@v1 with: From ff1f67e02480820f08e6bc3cafef0da951aeada7 Mon Sep 17 00:00:00 2001 From: jtr109 Date: Thu, 30 Jul 2020 11:19:53 +0800 Subject: [PATCH 7/8] name jobs --- .github/workflows/rust.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 95dda22..3abf379 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -11,6 +11,7 @@ env: jobs: test: + name: Test runs-on: ubuntu-latest steps: - name: Checkout repository @@ -20,6 +21,7 @@ jobs: coverage: # template: https://github.com/marketplace/actions/rust-tarpaulin + name: Coverage runs-on: ubuntu-latest steps: - name: Checkout repository From 603f30ae11ebface22b26921b267f709d1ddd7ba Mon Sep 17 00:00:00 2001 From: jtr109 Date: Thu, 30 Jul 2020 11:24:01 +0800 Subject: [PATCH 8/8] add codecov badge --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 3dbdfa8..23347a7 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,7 @@ # LeetCode in Rust ![Unittest](https://github.com/jtr109/leetcode-in-rust/workflows/Unittest/badge.svg) +[![codecov](https://codecov.io/gh/jtr109/leetcode-in-rust/branch/master/graph/badge.svg)](https://codecov.io/gh/jtr109/leetcode-in-rust) Resolving problems of LeetCode in RustLang.