example improvements #184
Draft
example improvements #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglerchris
requested changes
Nov 9, 2024
| @@ -41,6 +41,7 @@ path = "examples/html2text.rs" | |||
| env_logger = "0.10.1" | |||
| argparse = "0.2.2" | |||
| log = "0.4.20" | |||
| yansi = { version = "1.0.1", features = ["hyperlink"] } | |||
There was a problem hiding this comment.
Should remove the termion dependency if it's no longer used.
| Image(_) => { | ||
| styled = match annotation { | ||
| Default => styled, | ||
| Link(url) => styled.link(url).blue().underline().to_string(), |
There was a problem hiding this comment.
I don't think the hyperlinks should be on by default, but fine with an opt in option (--hyperlinks or similar).
| start.push(format!("{}", Fg(Blue))); | ||
| finish.push(format!("{}", Fg(Reset))); | ||
| format!( | ||
| "{} {}", |
There was a problem hiding this comment.
You can't add extra visible text here - the colour map function is not expected to change the size of any text, or it would mess up the formatting. As above, the hyperlink should only be done with an option to enable it.
| } | ||
| } | ||
| Strikeout => { | ||
| if !have_explicit_colour { | ||
| start.push(format!("{}", Fg(LightBlack))); | ||
| finish.push(format!("{}", Fg(Reset))); | ||
| styled.strike().to_string() |
There was a problem hiding this comment.
The text should already be struck out already by this point (using U+336).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yansiinstead oftermionfor colouring