Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deploy step to the workflow #45

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

t00sa
Copy link
Contributor

@t00sa t00sa commented Apr 18, 2024

This adds a script which carries out the actions required to build and release a new version of the jules documentation when the action is a push to the master branch if they do not exist for the most recent release tag.

The functionality was tested by creating a fork of the repository, change the name of the target repo in the workflow, adding a tag, and running the workflow. Various tests were also run without adding a new tag to confirm that the workflow ran a test build without attempting to make changes to the master branch.

This adds a script which carries out the actions required to build and
release a new version of the jules documentation when the action is a
push to the master branch if they do not exist for the most recent
release tag.

This partitions the workflow to trigger the build-only step when the
pushing to a branch or on a PR and only the deployment step when
pushing to master.
@t00sa t00sa linked an issue Apr 18, 2024 that may be closed by this pull request
@t00sa t00sa requested review from a team and richardgilham and removed request for a team April 22, 2024 13:39
Copy link
Contributor

@richardgilham richardgilham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good and makes sense. Design seems proportionate to its intended usage. A couple of minor comments inline.

Remove a holdover from testing from the workflow file, tidy up a
comment, and flip the logic used to commit updates to the branch to
streamline the code and make the behaviour more obvious.
@t00sa t00sa requested a review from richardgilham April 25, 2024 15:37
Copy link
Contributor

@richardgilham richardgilham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those. Approved!

@richardgilham richardgilham merged commit 19dbd37 into master Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs post 7.5 release
2 participants