Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example script #4

Merged
merged 1 commit into from
Dec 6, 2022
Merged

update example script #4

merged 1 commit into from
Dec 6, 2022

Conversation

ranocha
Copy link
Contributor

@ranocha ranocha commented Sep 1, 2022

This is based on some discussion we recently had in SciML, see SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29

This is based on some discussion we recently had in SciML, see SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29
Copy link
Member

@SaschaMann SaschaMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I don't know how the action works.

We should consider adding a reusable workflow that contains this, which would make it easier to maintain this workflow across all repos in an org like in the linked issue.

@ranocha
Copy link
Contributor Author

ranocha commented Sep 1, 2022

Here is an example when this test passes: https://github.com/SciML/MuladdMacro.jl/runs/8121563802?check_suite_focus=true

And here is a failing example: https://github.com/ranocha/InvalidationsTest.jl/runs/8134758303?check_suite_focus=true

We should consider adding a reusable workflow that contains this, which would make it easier to maintain this workflow across all repos in an org like in the linked issue.

Sounds good to me. But can we get this merged first to update the information?

@ranocha
Copy link
Contributor Author

ranocha commented Dec 6, 2022

Bump

@SaschaMann SaschaMann merged commit c0cb892 into julia-actions:main Dec 6, 2022
@SaschaMann
Copy link
Member

Sorry it took so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants